fix create report becomes unresponsive after deleting workspace

[huult]

Details

Fixed Issues

$ #73312
PROPOSAL: #73312 (comment)

Tests

Same QA step

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Preconditions:

• The account has a default workspace where the Per Diem feature is disabled.
• A second workspace with Per Diem rates has been created.

1. Go to Expensify app
2. Navigate to the second workspace chat.
3. Create a Per Diem expense in the workspace chat.
4. Open the expense report.
5. Click the Report field.
6. Click Remove from report.
7. Delete the second workspace that has Per Diem rates.
8. Go to Self DM.
9. Open the unreported Per Diem expense.
10. Verify that the Report field cannot be clicked or edited.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-11-01.at.12.49.57.mp4

Android: mWeb Chrome

Screen.Recording.2025-11-01.at.12.53.12.mp4

iOS: Native

Screen.Recording.2025-11-01.at.12.56.51.mp4

iOS: mWeb Safari

Screen.Recording.2025-11-01.at.12.59.38.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-11-01.at.12.41.26.mp4

MacOS: Desktop

Screen.Recording.2025-11-01.at.12.45.21.mp4

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

LGTM 👍 Thank you for your hard work!

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...rc/pages/iou/request/step/IOURequestStepReport.tsx	0.00% <0.00%> (ø)
...c/components/ReportActionItem/MoneyRequestView.tsx	0.28% <0.00%> (-0.01%)	⬇️
... and 6 files with indirect coverage changes

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[ikevin127]

@huult Based on the code changes, I found some regressions, the flawed logic is:

✅ Non-Per Diem: no change - canEditReport logic remains the same.
⚠️ Per Diem: canEditReport is now true only when exactly one eligible policy exists (policyForMovingExpensesID && !shouldSelectPolicy). With 0 or multiple eligible policies it will be disabled; this satisfies our “deleted workspace” case but is a behavior change for users with multiple Per Diem-enabled workspaces (previously they could pick).

After verifying testing step number 10:

10. Verify that the Report field cannot be clicked or edited.

❌ We have the following issues:

1. If we proceed to create 1 new workspace and enable Per Diem, then return to the selfDM per diem transaction, we can now click on the Report field and empty RHP opens

2. If we proceed to create 2 or more new workspaces and enable Per Diem for each, then return to the selfDM per diem transaction, the Report field cannot be clicked or edited (should be since we have multiple per diem enabled workspaces, right ?). Important: on iOS: mWeb Safari seems that Reports field is still enabled even with 2 per diem enabled workspaces, and the UI looks like issue 1 from above.

♻️ From this I think both canEditReport condition and IOURequestStepReport.tsx should be adjusted to fix these issues, while still addressing our OP issue.

[huult]

@ikevin127 I’ll take a look soon

[huult]

I will check and fix it tomorrow morning

[huult]

@ikevin127 Could you take a look at this video after I updated the new behavior? We have logic to check for an upgrade

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 317 in 6649879

const shouldNavigateToUpgradePath = !policyForMovingExpenses && !shouldSelectPolicy;

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 924 to 933 in 6649879

	if (shouldNavigateToUpgradePath) {
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_UPGRADE.getRoute({
	iouType,
	action: CONST.IOU.ACTION.EDIT,
	transactionID: transaction?.transactionID,
	reportID: report.reportID,
	upgradePath: CONST.UPGRADE_PATHS.REPORTS,
	}),
	);

Screen.Recording.2025-11-06.at.14.23.23.mov

After we upgraded, we have policyForMovingExpensesID and shouldSelectPolicy, but they belong to the transaction draft.

App/src/pages/iou/request/step/IOURequestStepUpgrade.tsx

Line 42 in 4ec5f12

const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {canBeMissing: true});

Inside IOURequestStepReport, when the action is EDIT, we use the actual transaction. So, we can’t navigate to the report step — as shown in the video above. Instead, it returns and shows the money request details again. What do you think about this behavior?

App/src/pages/iou/request/step/withFullTransactionOrNotFound.tsx

Line 88 in 4ec5f12

transaction={shouldUseTransactionDraft(userAction, userType) ? transactionDraftData : transaction}

Or after the upgrade, should we use the transaction draft to create the report instead?

[ikevin127]

@huult This changes things because our issue's actual result is changed due to the recently added 'upgrade path flow'. I asked on the issue regarding how to move forward - in the meantime you can add [HOLD] to the PRs title until we get a response 🙌

[heyjennahay]

No concern with product change

[ikevin127]

@huult Just checked, looks good now in terms of the new expectation that was agreed upon in the issue:

check if the unreported expense is Per diem and disable / make the Report field non-clickable (this would mean the upgrade path flow won't be reached for Per diem unreported expenses unless there's at least 1 workspace with Per diem enabled)

but there's still 1 issue left from my previous review:

2. If we proceed to create 2 or more new workspaces and enable Per Diem for each, then return to the selfDM per diem transaction, the Report field cannot be clicked or edited (should be since we have multiple per diem enabled workspaces, right ?). Important: on iOS: mWeb Safari seems that Reports field is still enabled even with 2 per diem enabled workspaces, and the UI looks like issue 1 from above.

Once ☝️ is fixed, let me know and I'll take another look.

ℹ️ Already present on staging: the only other issue I found is that even with a Per diem enabled WS, a selfDM Per diem expense cannot be transfered to a Per diem enabled WS for some reason, the only thing that can be done in the Reports RHP is to create an empty report on that Per diem enabled WS.

When report is already created and we select the expense report in Reports RHP for transfer, nothing happens and Per diem expense remains in self DM - we do get a "moved this expense to your personal space" report action though.

[huult]

Yes, I’m checking and will fix it.

[huult]

Screen.Recording.2025-11-21.at.12.42.12.mov

@ikevin127 I've updated the code. please review again. thank you!

[ikevin127]

♻️ Checking...

[ikevin127]

🟢 LGTM - thanks for addressing all issues!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅