Skip to content

[NO-QA]Use renamed git repo for change step#7409

Merged
roryabraham merged 1 commit into
mainfrom
andrew-rename
Jan 26, 2022
Merged

[NO-QA]Use renamed git repo for change step#7409
roryabraham merged 1 commit into
mainfrom
andrew-rename

Conversation

@AndrewGable

@AndrewGable AndrewGable commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

Details

futuratrepadeira/changed-files was renamed to umani/changed-files, I'm not sure it's causing errors in this repo, but it was in a different one, so let's just update to the renamed repo just in case.

Tests

  1. Merge this PR
  2. Verify that updateProtectedBranch.yml continues to check for the correct files changed

@AndrewGable AndrewGable self-assigned this Jan 25, 2022
@AndrewGable AndrewGable requested a review from a team as a code owner January 25, 2022 23:59
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team January 25, 2022 23:59

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this commit hash in the umani repo:

image

I guess the commits got renamed along with the repo 🤷

@AndrewGable

Copy link
Copy Markdown
Contributor Author

I see it here: umani/changed-files@1d252c6

@roryabraham

Copy link
Copy Markdown
Contributor

Weird, I see the same commit with a different hash:

image

umani/changed-files@ca328eb

@roryabraham roryabraham merged commit 57a1c40 into main Jan 26, 2022
@roryabraham roryabraham deleted the andrew-rename branch January 26, 2022 01:01
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@AndrewGable

Copy link
Copy Markdown
Contributor Author

Screen Shot 2022-01-25 at 6 01 26 PM

Screen Shot 2022-01-25 at 6 01 19 PM

I think the hash changes based on which branch you are looking at.

I used the hash that was listed under the lastest release, which must not have used the master branch

Screen Shot 2022-01-25 at 6 02 18 PM

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants