Skip to content

Remove extra margin from close account button#7419

Merged
Julesssss merged 2 commits into
Expensify:mainfrom
parasharrajat:close-account-page
Feb 8, 2022
Merged

Remove extra margin from close account button#7419
Julesssss merged 2 commits into
Expensify:mainfrom
parasharrajat:close-account-page

Conversation

@parasharrajat

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #7378

Tests | QA Steps

  1. Open the app
  2. Navigate to Settings>Security>Close Account
  3. Check Close Button
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Mobile Web | Desktop

image

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner January 26, 2022 13:25
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team January 26, 2022 13:25
@parasharrajat

Copy link
Copy Markdown
Member Author

cc: @Julesssss let me know if you are waiting for the rest of the screenshots. Otherwise it's ready.

@Julesssss

Copy link
Copy Markdown
Contributor

Oh sorry, I completely missed this one.

@parasharrajat

Copy link
Copy Markdown
Member Author

cc: @Julesssss This is ready for merge.

@parasharrajat

Copy link
Copy Markdown
Member Author

@Julesssss I think this can be merged.

@Julesssss Julesssss merged commit 2ee7820 into Expensify:main Feb 8, 2022
@Julesssss

Copy link
Copy Markdown
Contributor

Yep. Sorry, I lost the issue again.

@OSBotify

OSBotify commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants