[Performance] Lazy Loading In Metro Config#7430
Merged
Merged
Conversation
Contributor
|
Did you feel any changes in a quick test? I'm kind of concerned that this may not be the only change needed? |
Contributor
Author
Not really... but I don't have a ton of chats on my dev account. This change was recommended by our outsourced performance team that intends to work with us soon. They mentioned this was something we could do immediately. |
danieldoglas
approved these changes
Jan 28, 2022
danieldoglas
left a comment
danieldoglas
left a comment
Contributor
There was a problem hiding this comment.
LGTM, and passed the tests.
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
46 tasks
Contributor
|
🚀 Deployed to staging by @danieldoglas in version: 1.1.33-4 🚀
|
Contributor
|
🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This change was recommended by {callstack} as a little freebee improvement we could make immediately.
@AndrewGable, How familiar are you with the metro config, I see your name here in the blame.
Fixed Issues
$ GH_LINK
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android