Skip to content

Fix button padding on IOU Details page#7443

Merged
chiragsalian merged 1 commit into
mainfrom
monil-fixButtonPadding
Jan 27, 2022
Merged

Fix button padding on IOU Details page#7443
chiragsalian merged 1 commit into
mainfrom
monil-fixButtonPadding

Conversation

@MonilBhavsar

@MonilBhavsar MonilBhavsar commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

Use FixedFooter component instead of View with custom style

Details

Fixed Issues

$ #7441

Tests

  1. Request money multiple times from a user
  2. Make sure Payment button has no padding at the top
  • Verify that no errors appear in the JS console

QA Steps

  1. Requested money multiple times from a user
  2. Make sure Payment button has no padding at the top
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-27.at.4.52.28.PM.mov

Mobile Web

Desktop

iOS

Simulator Screen Shot - iPhone 12 - 2022-01-27 at 21 03 25

Android

Screenshot_1643295386

@MonilBhavsar MonilBhavsar self-assigned this Jan 27, 2022
@MonilBhavsar MonilBhavsar marked this pull request as ready for review January 27, 2022 15:34
@MonilBhavsar MonilBhavsar requested a review from a team as a code owner January 27, 2022 15:34
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team January 27, 2022 15:34

@bondydaa bondydaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems simple enough. going to try and also get someone who's more familiar to review as well though since I haven't done much with new dot.

@bondydaa bondydaa requested a review from a team January 27, 2022 21:16

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team January 27, 2022 21:16

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. LGTM.

@chiragsalian chiragsalian merged commit 90533cd into main Jan 27, 2022
@chiragsalian chiragsalian deleted the monil-fixButtonPadding branch January 27, 2022 21:19
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants