Skip to content

[No QA] Bump eslint-config-expensify version to 2.0.23#7455

Merged
mountiny merged 2 commits into
mainfrom
cmartins-bumpEsLintVersion
Jan 28, 2022
Merged

[No QA] Bump eslint-config-expensify version to 2.0.23#7455
mountiny merged 2 commits into
mainfrom
cmartins-bumpEsLintVersion

Conversation

@luacmartins

@luacmartins luacmartins commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

Details

Bump eslint-config-expensify version and update js-lint errors.

cc @roryabraham

Fixed Issues

$ #7454

Tests

  1. Run the app
  2. Verify that there is no js-lint error in terminal.
  • Verify that no errors appear in the JS console

QA Steps

None.

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins self-assigned this Jan 28, 2022
@luacmartins luacmartins changed the title Bump eslint-config-expensify version to 2.0.23 [No QA] Bump eslint-config-expensify version to 2.0.23 Jan 28, 2022
@luacmartins luacmartins marked this pull request as ready for review January 28, 2022 18:24
@luacmartins luacmartins requested a review from a team as a code owner January 28, 2022 18:24
@MelvinBot MelvinBot requested review from mountiny and removed request for a team January 28, 2022 18:25

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! all checks are passing, that means we can go ahead 🚢

@mountiny mountiny merged commit 2cdb7c3 into main Jan 28, 2022
@mountiny mountiny deleted the cmartins-bumpEsLintVersion branch January 28, 2022 20:41
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants