Sync workspace member across devices after removing member(s)

[K4tsuki]

Details

Sync workspace member across device after member(s) removed.

Fixed Issues

$ #7095

Tests

• Verify that no errors appear in the JS console

1. Open workspace member page with same account on two device
2. Remove member(s) on a device and refresh member page in other device
3. Members of workspace must be same on those two device
4. In android must go back to setting page and then go to member page to update the member list.

QA Steps

• Verify that no errors appear in the JS console

1. Open workspace member page with same account on two device
2. Remove member(s) on a device and refresh member page in other device
3. Members of workspace must be same on those two device
4. In android must go back to setting page and then go to member page to update the member list.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

remove_web.mp4

Mobile Web

remove_c_mweb.mp4

Desktop

iOS

Android

android_remove.mp4

[K4tsuki]

Fixing lint error

[parasharrajat]

Works fine for the linked issue.

There could be unintended side-effects of this change. withFullPolicy is used on all workspace pages. we use Onyx.merge to merge the changes but for this we are using Onyx.set. There are limitations of using Onyx.set. It cancels the merge requests which could interfere with other Workspace pages operations. This is an assumption so It is possible that it never happens.

But Onyx poses a challenge for us and it does not give us any other choice to fix the linked issue ATM. So I am approving this.

cc: @Luke9389

🎀 👀 🎀 C+ reviewed

[K4tsuki]

cc: @Luke9389 All checks have passed

[Luke9389]

There could be unintended side-effects of this change.

@parasharrajat, this concerns me. Before approving I'm going to go read up on Onyx and be sure this change is exactly what we want it to be.

[K4tsuki]

@Luke9389 We have been using Onyx.set in removeMember and there was no problem because of this.

App/src/libs/actions/Policy.js

Line 299 in 16d38de

Onyx.set(key, policyDataWithMembersRemoved);

Also Kidroca tell to us to using Onyx.set in this issue in slack conversation.

I have tested it on navigating between workspaces, add and remove members and there is no problem.

[Luke9389]

Looks like there's now a merge conflict. Please merge main

[K4tsuki]

@Luke9389 main merged.

[Luke9389]

After reviewing some materials, I think this is fine.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Luke9389 in version: 1.1.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅