Update CONTRIBUTING.md#7490
Conversation
Added - Please use the templates for bugs and feature requests that are bookmarked in #expensify-open-source. Removed text about inc. details cuz those are in the template.
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Should we maybe include a link to the How to create a plan instruction somewhere in this file too?
|
Yes! Good call @mountiny , can you see where it'd fit best and add it? (it'll be quicker for you, I imagine) |
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Left a suggestion there, feel free to adjust it as you find best.
| 4. If there is no existing GitHub issue or Upwork job, check if the issue is happening on prod (as opposed to only happening on dev) | ||
| 5. If the issue is just in dev then it means it's a new issue and has not been deployed to production. In this case, you should try to find the offending PR and comment in the issue tied to the PR and ask the assigned users to add the `DeployBlockerCash` label. If you can't find it, follow the reporting instructions in the next item, but note that the issue is a regression only found in dev and not in prod. | ||
| 6. If the issue happens in production then report the issue(s) in the [#expensify-open-source](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#asking-questions) Slack channel, prefixed with `BUG:` or `Feature Request:`. Include all relevant data, screenshots and examples in the post or thread. | ||
| 6. If the issue happens in production then report the issue(s) in the [#expensify-open-source](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#asking-questions) Slack channel, prefixed with `BUG:` or `Feature Request:`. Please use the templates for bugs and feature requests that are bookmarked in #expensify-open-source. |
There was a problem hiding this comment.
@mallenexpensify To be honest, I believe this line is the best in this file. I feel like the instructions are most handy when someone wants to propose a new feature, which is mentioned on this line. So I suggest:
| 6. If the issue happens in production then report the issue(s) in the [#expensify-open-source](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#asking-questions) Slack channel, prefixed with `BUG:` or `Feature Request:`. Please use the templates for bugs and feature requests that are bookmarked in #expensify-open-source. | |
| 6. If the issue happens in production then report the issue(s) in the [#expensify-open-source](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#asking-questions) Slack channel, prefixed with `BUG:` or `Feature Request:`. Please use the templates for bugs and feature requests that are bookmarked in #expensify-open-source. For instructions on how to come up with a plan, which could be useful for you in this stage especially in case of a feature request, please refer to [this guide](https://github.com/Expensify/App/blob/main/HOW_TO_CREATE_A_PLAN.md). |
There was a problem hiding this comment.
@mountiny , this shortened version will likely work better.
View this guide for help creating a plan when proposing a feature request
How would I delete yours and add mine above? I'm unfamiliar with editing a PR
There was a problem hiding this comment.
@mallenexpensify I think what you can do is to click on the branch name here:
mallenexpensify-patch-1 in this case. That will bring you to your version of the code which we can see in this PR. Then navigate to the Contributing file https://github.com/Expensify/App/blob/mallenexpensify-patch-1/CONTRIBUTING.md
And then you cum click the pencil button same as before, make the changes and commit it.
|
Thanks @mountiny , that gets me to the edit page but I don't see your proposed changes there to edit Would I just make the intended final edits there then Github would use 'magic' to decipher the differences between your recommended updates and mine? |
|
@mallenexpensify That is correct, what you will see there are only the changes you have made. You can then copy this line and put it in there and in the bottom add commit and it will show up here! |
> View [this guide](https://github.com/Expensify/App/blob/main/HOW_TO_CREATE_A_PLAN.md) for help creating a plan when proposing a feature request.
|
I did what you recommended above @mountiny , should it show up here now? |
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Yes! Amazing! You can see in the top header menu in the PR that there are 2 commits.
Jut gonna wait for the tests.
|
@mountiny looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀
|
4 participants
Added -
Please use the templates for bugs and feature requests that are bookmarked in #expensify-open-source.Removed text about inc. details cuz those are in the template.
Details
Added -
Please use the templates for bugs and feature requests that are bookmarked in #expensify-open-source.Removed text about inc. details cuz those are in the template.
Fixed Issues
$ GH_LINK
Tests
Ensure text reads
Please use the templates for bugs and feature requests that are bookmarked in #expensify-open-source.QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android