pointer on top within close account page#7498
Merged
Merged
Conversation
MelvinBot
requested review from
iwiznia and
parasharrajat
and removed request for
a team
parasharrajat
suggested changes
Feb 1, 2022
parasharrajat
left a comment
parasharrajat
left a comment
Member
There was a problem hiding this comment.
Change looks good. But please fix the template
Then test it on all platforms and add the screenshots. We are on the verge of making this mandatory for all PRs.
Contributor
Author
|
@parasharrajat tested on all platforms and fixed the template |
parasharrajat
approved these changes
Feb 1, 2022
Contributor
Author
|
@iwiznia do you think we have to change something, or its ok for this PR? |
iwiznia
approved these changes
Feb 7, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
49 tasks
Contributor
Contributor
|
🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Style change for pointer to start on top on android on close account page
Fixed Issues
$ #7380
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android