Skip to content

Disable guides calling if user is blocked from concierge#7511

Merged
stitesExpensify merged 8 commits into
mainfrom
puneet-banned-inboxcall
Feb 3, 2022
Merged

Disable guides calling if user is blocked from concierge#7511
stitesExpensify merged 8 commits into
mainfrom
puneet-banned-inboxcall

Conversation

@puneetlath

@puneetlath puneetlath commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

Details

This PR makes it so that if a user is blocked from talking to Concierge they are also blocked from starting a Guides call. cc @stitesExpensify

Fixed Issues

$ #7499

Screen.Recording.2022-02-02.at.4.53.27.PM.mov

Tests

  • Verify that no errors appear in the JS console
  1. Sign into an account in New Dot and navigate to your Concierge chat
  2. Message Concierge
  3. Go to https://www.expensify.com.dev/concierge/#/tools/ChatSearchByUser and find the chat with your user
  4. Click User Info and block the user
  5. Go back to New Dot and try to start a call
  6. You should see a growl saying that calling is blocked
  7. The call button should become disabled with a warning message above explaining why
  8. Close the call modal, refresh the page, and open the call modal again
  9. You should still see the call button as disabled with the message above it

QA Steps

  • Verify that no errors appear in the JS console
  1. Sign into an account in New Dot and navigate to your Concierge chat
  2. Message Concierge
  3. Go to https://www.expensify.com/concierge/#/tools/ChatSearchByUser and find the chat with your user
  4. Click User Info and block the user
  5. Go back to New Dot and try to start a call
  6. You should see a growl saying that calling is blocked
  7. The call button should become disabled with a warning message above explaining why
  8. Close the call modal, refresh the page, and open the call modal again
  9. You should still see the call button as disabled with the message above it

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2022-02-02 at 5 02 58 PM

Mobile Web

Screen Shot 2022-02-02 at 5 12 14 PM

Desktop

Screen Shot 2022-02-02 at 5 15 19 PM

iOS

Screen Shot 2022-02-02 at 5 10 23 PM

Android

Screen Shot 2022-02-02 at 5 35 20 PM

@puneetlath puneetlath self-assigned this Feb 1, 2022
@puneetlath

Copy link
Copy Markdown
Contributor Author

@Expensify/design any opinion on red vs gray exclamation icon? This text will appear above the call me button when it is disabled due to a user having been blocked from interacting with concierge/guides.

Screen Shot 2022-02-01 at 5 03 16 PM

Screen Shot 2022-02-01 at 5 02 21 PM

@michelle-thompson

Copy link
Copy Markdown
Contributor

I wonder if we could do yellow instead? Red feels extreme in this context.

@puneetlath puneetlath added the InternalQA This pull request required internal QA label Feb 2, 2022
@puneetlath puneetlath changed the title Disable guides calling if user is blocked from concierge [Internal QA] Disable guides calling if user is blocked from concierge Feb 2, 2022
@puneetlath puneetlath changed the title [Internal QA] Disable guides calling if user is blocked from concierge Disable guides calling if user is blocked from concierge Feb 2, 2022
@puneetlath puneetlath marked this pull request as ready for review February 2, 2022 22:44
@puneetlath puneetlath requested a review from a team as a code owner February 2, 2022 22:44
@MelvinBot MelvinBot requested review from timszot and removed request for a team February 2, 2022 22:44
timszot
timszot previously approved these changes Feb 2, 2022

@timszot timszot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but since I'm still learning a lot for newDot, leaving for @stitesExpensify for final review.

stitesExpensify
stitesExpensify previously approved these changes Feb 3, 2022
Comment thread src/languages/en.js Outdated
Comment thread src/pages/RequestCallPage.js
@puneetlath puneetlath dismissed stale reviews from stitesExpensify and timszot via 83c3c64 February 3, 2022 20:14

@timszot timszot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice edits, thanks!

@stitesExpensify stitesExpensify merged commit d00f353 into main Feb 3, 2022
@stitesExpensify stitesExpensify deleted the puneet-banned-inboxcall branch February 3, 2022 21:50
@MelvinBot

Copy link
Copy Markdown
Contributor

Triggered auto assignment to @francoisl (InternalQA), see https://stackoverflow.com/c/expensify/questions/5042 for more details.

@botify

botify commented Feb 3, 2022

Copy link
Copy Markdown

@stitesExpensify looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

OSBotify commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@stitesExpensify

Copy link
Copy Markdown
Contributor

All tests had passed when this was merged. This is a bug https://github.com/Expensify/Expensify/issues/189984

@francoisl

Copy link
Copy Markdown
Contributor

#7511 (comment)

We have internal QA on Expensify/App PRs now? Anyway it looks like it's not deployed to staging yet so I'll check again later.

@OSBotify

OSBotify commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@francoisl

Copy link
Copy Markdown
Contributor

Internal QA 👍

Screen Shot 2022-02-04 at 10 51 05 AM

@OSBotify

OSBotify commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants