Aligned header#7512
Conversation
MelvinBot
requested review from
mountiny and
parasharrajat
and removed request for
a team
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
@mateusbra Could you please also add a screenshot for Safari iOS in the mobile Web category? Not a big deal but the styles sometimes get screwed for mobile safari.
|
@mountiny sure! |
|
@mountiny PR updated with Safari IOS on Web and mWeb categories Screenshots |
There was a problem hiding this comment.
LGTM.
Please change the test steps:
3. Observe that all the subpages are aligned
- Check header title is vertically centered on all pages where there is a header. E.g. Settings pages.
- Note: that it should not affect the header where the subtitle is also visible. e.g. Attachment modal.
cc: @mountiny
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@mateusbra Thank you for working on this! 🙇 and @parasharrajat for a review! |
|
🚀 Deployed to production by @sketchydroide in version: 1.1.35-1 🚀
|
|
@mateusbra For future PRs, please, make sure the linked issue is written using the following format: What you have there now is: We have automation in place, which requires this format to work properly (for example the issue has not been updated with a date when we should pay you). Thank you for keeping your eye on this in future! |
|
@mountiny sure! Sorry for that. I'll ensure future PR's will follow the correct format 😅 |
|
No problem at all! 🙇 |
4 participants
Details
Style fix for settings subpages miss-aligned headers on IOS and Android
Fixed Issues
$ #7491
Tests | QA Steps
Tested On
Screenshots
Web
Chrome:
Safari:
Mobile Web
Android chrome mWeb:
IOS safari mWeb:
Desktop
iOS
Android