Skip to content

fix ios text input size#7513

Merged
luacmartins merged 2 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui/ios-text-input
Feb 2, 2022
Merged

fix ios text input size#7513
luacmartins merged 2 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui/ios-text-input

Conversation

@thesahindia

Copy link
Copy Markdown
Member

Details

Fixed the size of ios multiline TextInput

Fixed Issues

$ #7495

Tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Open ios app
  2. Navigate to Settings >Security > Close account
  3. Verify that the multiline TextInput is not different from other platforms
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2022-02-02 at 1 53 36 PM

Mobile Web

Screenshot 2022-02-02 at 1 51 18 PM

Desktop

Screenshot 2022-02-02 at 1 55 00 PM

iOS

Screenshot 2022-02-02 at 1 49 07 PM

Android

Screenshot 2022-02-02 at 1 49 51 PM

@thesahindia thesahindia requested a review from a team as a code owner February 2, 2022 08:33
@MelvinBot MelvinBot requested review from luacmartins and rushatgabhane and removed request for a team February 2, 2022 08:33
Comment thread src/pages/settings/Security/CloseAccountPage.js Outdated
rushatgabhane
rushatgabhane previously approved these changes Feb 2, 2022

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luacmartins Tests well on all platforms, LGTM!

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes @thesahindia!

@luacmartins luacmartins merged commit 6fc16aa into Expensify:main Feb 2, 2022
@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants