[No QA] Fix lock comment#7533
Merged
Merged
Conversation
MelvinBot
requested review from
stitesExpensify
and removed request for
a team
stitesExpensify
approved these changes
Feb 3, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
22 tasks
Contributor
|
🚀 Deployed to staging by @stitesExpensify in version: 1.1.36-0 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixes an oops. Need double-quotes for variable expansion in bash.
Fixed Issues
$ n/a – see here:
broken comment
fixed comment
Tests
You can test the bash command to verify that the fix works (need the GitHub CLI installed):
gh issue comment \ $(gh issue list --label StagingDeployCash --json number --jq '.[0].number') \ --body ":rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/$(< package.json jq -r .version) :rocket:"Tested On
Bash/GitHub