Skip to content

Allow hitting production web-secure from staging#7534

Merged
stitesExpensify merged 1 commit into
mainfrom
marcaaron-fixStagingSecure
Feb 2, 2022
Merged

Allow hitting production web-secure from staging#7534
stitesExpensify merged 1 commit into
mainfrom
marcaaron-fixStagingSecure

Conversation

@marcaaron

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

$ #7371

Tests

There's no way to test this on dev really.

QA Steps

  1. Ensure the user preference for the staging secure server toggle is off
  2. Try to log in with the Chase credentials
  3. Verify it doesn't work (because we are not on staging secure)
  4. Toggle to staging secure server
  5. Try to log in with the Chase credentials
  6. Verify we can do so now since we are in the sandbox
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron added the InternalQA This pull request required internal QA label Feb 2, 2022
@marcaaron marcaaron requested a review from a team as a code owner February 2, 2022 21:18
@marcaaron marcaaron self-assigned this Feb 2, 2022
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team February 2, 2022 21:18
@stitesExpensify stitesExpensify merged commit 6406656 into main Feb 2, 2022
@stitesExpensify stitesExpensify deleted the marcaaron-fixStagingSecure branch February 2, 2022 22:22
@MelvinBot

Copy link
Copy Markdown
Contributor

Triggered auto assignment to @danieldoglas (InternalQA), see https://stackoverflow.com/c/expensify/questions/5042 for more details.

@botify

botify commented Feb 2, 2022

Copy link
Copy Markdown

@stitesExpensify looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@stitesExpensify

Copy link
Copy Markdown
Contributor

This was merged with passing tests. Issue is here https://github.com/Expensify/Expensify/issues/189984

@OSBotify

OSBotify commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham

roryabraham commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Tried testing this and I get a CSP error on staging when I try to click "Add bank account":

image

@danieldoglas

Copy link
Copy Markdown
Contributor

I was testing just now and got the same as @roryabraham

@roryabraham

Copy link
Copy Markdown
Contributor

Technically, this is QA pass because trying to log in didn't work :trollface:

@roryabraham

Copy link
Copy Markdown
Contributor

I'm going to work on fixing the CSP

@roryabraham

Copy link
Copy Markdown
Contributor

@roryabraham

Copy link
Copy Markdown
Contributor

CSP is fixed:

image

@roryabraham

Copy link
Copy Markdown
Contributor

I did the following:

  1. Ensured that the Use staging secure server toggle was off.
  2. Tried to add a Chase bank account. Was taken to production Chase OAuth, and the sandbox credentials didn't work.
  3. Toggled the Use staging secure server on.
  4. Tried to add a Chase bank account. Ended up using Plaid sandbox mode (was not taken to actual production Chase OAuth login site), and sandbox credentials worked.

Which I think means this is a QA pass ✅ 🎉

@OSBotify

OSBotify commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants