Skip to content

Fix broken max length in "SNN Last 4 digits" input #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 2 commits into from
Feb 3, 2022
+0 −8
Merged

Fix broken max length in "SNN Last 4 digits" input #7551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7152a99
Remove maxLength prop from baseTextInputPropTypes
aldo-expensify Feb 3, 2022
c6c51cc
Remove unused "hint" prop
aldo-expensify Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/components/TextInput/baseTextInputPropTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,6 @@ const propTypes = {

/** Saves a draft of the input value when used in a form */
shouldSaveDraft: PropTypes.bool,

/** Character limit for the input */
maxLength: PropTypes.number,
Comment thread
luacmartins marked this conversation as resolved.

/** Hint microcopy to be displayed under the input */
hint: PropTypes.string,
};

const defaultProps = {
Expand All @@ -72,8 +66,6 @@ const defaultProps = {
defaultValue: undefined,
forceActiveLabel: false,
shouldSaveDraft: false,
maxLength: undefined,
hint: '',
};

export {propTypes, defaultProps};