fix/75255 - migrate icons/illustration communication & socials - money & finance to lazy loading

[NJ-2020]

Explanation of Change

This PR migrate icons & illustration to lazy loading:

Icons:

• ChatBubble
• ChatBubbles
• ChatBubbleCounter
• ChatBubbleReply
• ChatBubbleUnread
• CommentBubbles
• Concierge
• Emoji
• Facebook
• Instagram
• Linkedin
• Podcast
• Twitter
• Youtube
• Mail
• Bank
• Bill
• Cash
• Coins
• CreditCard
• CreditCardExclamation
• CreditCardHourglass
• EReceiptIcon
• Invoice
• InvoiceGeneric
• MoneyBag
• MoneyCircle
• MoneyHourglass
• MoneySearch
• MoneyWaving
• Receipt
• ReceiptMultiple
• ReceiptPlaceholderPlus
• ReceiptPlus
• ReceiptScan
• ReceiptSlash
• ReceiptBody
• ReplaceReceipt
• Transfer
• Wallet

Illustration: ChatBubbles

Fixed Issues

$ #75255
PROPOSAL: #75255 (comment)

Tests

Open the following pages and verify the icon is loaded properly:

• AddPaymentMethodMenu: KYC wall payment method selection (appears during Pay flow when selecting payment method)

• EReceiptThumbnail: Transaction receipt views, Per Diem receipts

• EmojiPickerButton: Report composer, Message edit mode (Chat → Emoji button in composer)

• EmojiPickerButtonDropdown: Custom Status page (Settings → Status → Emoji dropdown)

• FloatingCameraButton: Bottom navigation bar floating camera button (web only, resize the screen to be narrow layout)

• FloatingReceiptButton: Left sidebar, above FAB button (wide/web layout only)

• MigratedUserWelcomeModal: Modal for migrated users (appears after login for users migrated from classic)

• MoneyReportHeader: Expense Report page header (Expense Report with multiple transactions → Header)

• MoneyRequestHeader: Single Expense page header (Single transaction IOU report → Header)

• MoneyRequestReportTransactionList: Expense Report transaction list section

• SearchMoneyRequestReportEmptyState: Expense Report empty state (when no matching transactions)

• PDFThumbnailError: PDF thumbnail error state (when PDF preview fails to load)

• PopoverMenu: Various dropdown menus (FAB, ThreeDots, Composer +, Search, Video player)

• PromotedActionsBar: Report Details or Profile page (action buttons: Join/Message/Share/Pin)

• ReceiptAlternativeMethods: Scan receipt step (FAB → Create Expense → Scan tab → alternative methods section)

• ReceiptEmptyState: Expense view without receipt (placeholder with + icon)

• MoneyRequestReportPreviewContent: Chat message expense report preview (IOU preview card in chat)

• ReportActionItemImage: Receipt thumbnails in chat and expense views

• SettlementButton: Pay button (Search → Pay, Expense confirmation → Pay, Report header)

• TabSelector: Tabbed pages (Share page, Create Expense tabs, New Chat page, Receipt Partner invite)

• ChatBubbleCell: Transaction list rows in Search (comment count indicator)

• ReceiptCell: Transaction list rows in Search (receipt thumbnail)

• TypeCell: Transaction list rows in Search (expense type icon: Card/Cash/Distance)

• useBulkPayOptions: Search page bulk actions (Select transactions → Bulk pay dropdown)

• usePaymentOptions: MoneyReportHeader Pay button options dropdown

• useSearchTypeMenu: Search type popover menu (Search header dropdown, narrow layout)

• QuickActionUtils (getQuickActionIcon): FAB quick action icon (Home → FAB menu → Quick action contextual icon)

• ReportUtils (getAddExpenseDropdownOptions): Add Expense dropdowns (Expense Report header/list/preview → + Add)

• SearchUIUtils (getSuggestedSearches, createTypeMenuSections): Search sidebar menu items/icons

• getIconForAction: Expense action icons (FAB menu, Composer + menu, Quick actions)

• SetupMethod: Enable Payments Add Bank Account page (Settings → Wallet → Add Bank Account)

• Finish (NonUSD): Non-USD Bank Account finish step (Workspace → Bank Account → Non-USD flow completion)

• FinishChatCard: USD Bank Account finish step (Workspace → Bank Account → USD flow completion)

• VerifiedBankAccountFlowEntryPoint: Bank account setup entry (Reimbursement account flow start)

• SearchTypeMenu: Search sidebar menu (Search page → Left sidebar, wide layout)

• ShareCodePage: Share QR code page (Settings → Share Code, or Report Details → Share)

• AttachmentPickerWithMenuItems: Report composer + menu (Chat → + button in composer)

• FloatingActionButtonAndPopover: FAB menu (Home → Green + button)

• SplitBillDetailsPage: Split bill details (Chat → Split transaction → View details)

• InitialSettingsPage: Main settings page (Bottom nav → Account/Settings tab)

• CardSection: Subscription card section (Settings → Subscription → Card section)

• CardSectionActions: Subscription card actions (Settings → Subscription → Card → Actions menu, web only)

• CardSectionDataEmpty: Subscription no card state (Settings → Subscription → Empty card, native only)

• SubscriptionSettings: Subscription settings section (Settings → Subscription → Settings options)

• TaxExemptActions: Tax exemption menu (Settings → Subscription → Tax Exempt → Actions, web only)

• TransferBalancePage: Transfer balance page (Settings → Wallet → Transfer Balance)

• Socials: Sign-in page footer (Sign-in page → Social media links at bottom)

• WorkspaceMemberDetailsPage: Workspace member details (Workspace → Members → Select member)

• WorkspaceOwnerChangeErrorPage: Owner change error (Workspace → Change Owner flow → Error)

• WorkspaceReceiptPartnersPage: Receipt partners page (Workspace → Receipt Partners)

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/EReceiptThumbnail.tsx	71.79% <100.00%> (ø)
src/components/EmojiPicker/EmojiPickerButton.tsx	81.81% <100.00%> (+1.81%)	⬆️
src/components/FloatingReceiptButton.tsx	100.00% <100.00%> (ø)
src/components/MoneyReportHeader.tsx	0.00% <ø> (ø)
src/components/PopoverMenu.tsx	79.03% <100.00%> (+0.11%)	⬆️
src/components/PromotedActionsBar.tsx	36.36% <100.00%> (+6.36%)	⬆️
src/components/ReceiptAlternativeMethods.tsx	100.00% <100.00%> (ø)
src/components/ReceiptEmptyState.tsx	100.00% <100.00%> (ø)
...ReportPreview/MoneyRequestReportPreviewContent.tsx	59.93% <100.00%> (ø)
...ponents/ReportActionItem/ReportActionItemImage.tsx	71.05% <100.00%> (+0.78%)	⬆️
... and 41 more
... and 9 files with indirect coverage changes

[melvin-bot]

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[NJ-2020]

@mollfpr I've done all. However, I am not too sure about migrating icons in src/stories to lazy loading. I couldn't find any example for this folder. Any hint?

Many thanks

cc: @jjcoffee

[NJ-2020]

@NJ-2020 Could you resolve the conflict and add a test step to verify the migrated assets is working fine? Thanks!

@mollfpr Sorry for the delay, I was busy with local work, it should be ready soon. Thanks

[NJ-2020]

@mollfpr Done ✅

[mollfpr]

Thank you @NJ-2020! Could you resolve the conflict one last time? 🙏

[NJ-2020]

Done

[jjcoffee]

@NJ-2020 You have conflicts, can you take a look?

[NJ-2020]

@NJ-2020 You have conflicts, can you take a look?

Resolved ☑️

[jjcoffee]

@mollfpr Let's get this merged 🙏

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.85-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅