[No QA] Standardize on a way Windows/Linux can test MacOS and iOS apps#7555
Merged
Conversation
Link a document to test iOS and MacOS app on a windows/linux device.
Contributor
|
Thanks for putting this together @rushatgabhane , looks great |
MonilBhavsar
reviewed
Feb 4, 2022
MonilBhavsar
left a comment
MonilBhavsar
left a comment
Contributor
There was a problem hiding this comment.
Going through the doc, one is redirected to pastebin site for some commands. Can you please move those commands to the doc
Member
Author
|
@MonilBhavsar good idea, done. I hope this is okay.
|
MonilBhavsar
approved these changes
Feb 4, 2022
MonilBhavsar
left a comment
MonilBhavsar
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks great 👍
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
rushatgabhane
changed the title
22 tasks
Contributor
|
🚀 Deployed to staging by @MonilBhavsar in version: 1.1.36-0 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @mallenexpensify
You can checkout the end result over here - https://github.com/rushatgabhane/Expensify-App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms
Details
Make tests on all platforms mandatory, and link a doc for Windows/Linux users to test the iOS and MacOS app.
This PR adds the following text to CONTRIBUTING.md
Make sure you can test on all platforms
Fixed Issues
$ #7485