Clear search text input in new group page after select a user#7558
Merged
Conversation
MelvinBot
requested review from
parasharrajat and
pecanoro
and removed request for
a team
parasharrajat
previously approved these changes
Feb 4, 2022
parasharrajat
left a comment
parasharrajat
left a comment
Member
There was a problem hiding this comment.
LGTM. For now, I am skipping the screenshot check for Desktop and IOS which should work as change is purely logical.
cc: @pecanoro
🎀 👀 🎀 C+ reviewed
pecanoro
requested changes
Feb 4, 2022
| } | ||
|
|
||
| this.value = this.props.value; | ||
| if (this.props.value === '') { |
Contributor
There was a problem hiding this comment.
It looks good but can you leave a comment before the if condition explaining why we need to do this?
Contributor
Author
There was a problem hiding this comment.
I have add the comment
added 3 commits
February 4, 2022 22:22
parasharrajat
suggested changes
Feb 4, 2022
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
pecanoro
previously approved these changes
Feb 4, 2022
parasharrajat
suggested changes
Feb 4, 2022
parasharrajat
left a comment
parasharrajat
left a comment
Member
There was a problem hiding this comment.
lint issues @K4tsuki....
Contributor
Author
|
lint error fixed |
pecanoro
approved these changes
Feb 7, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
18 tasks
Contributor
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Clear search input in New Group page after select a user.
Fixed Issues
$ #6872
Tests
QA Steps
Tested On
Screenshots
Web
clear_groupsearch.mp4
Mobile Web
clear_groupsearch_mweb.mp4
Desktop
iOS
Android
video_2022-02-04_10-38-12.mp4