Skip to content

Position tolltip in appropriate place#7559

Merged
mountiny merged 1 commit into
Expensify:mainfrom
sobitneupane:tooltip-position
Feb 6, 2022
Merged

Position tolltip in appropriate place#7559
mountiny merged 1 commit into
Expensify:mainfrom
sobitneupane:tooltip-position

Conversation

@sobitneupane

@sobitneupane sobitneupane commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Details

Solves the issue of tooltip positioning. The issue is occurring in Web and Desktop App. I have tested on Web and would like to request reviewer to double check on Desktop App as I don't have access to macOS. Thanks.

Fixed Issues

$ #7481

Tests

  • Create an account using a very long email address.
  • Create two other accounts with short first names
  • From a fourth account, create a group chat will all three accounts from the previous two steps.
  • Send a message in the group chat.
  • Open the search page and search for the group chat.
  • Hover over the long email address

QA Steps

  • Create an account using a very long email address.
  • Create two other accounts with short first names
  • From a fourth account, create a group chat will all three accounts from the previous two steps.
  • Send a message in the group chat.
  • Open the search page and search for the group chat.
  • Hover over the long email address

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot from 2022-02-04 14-07-44
Screenshot from 2022-02-04 14-07-40
Screenshot from 2022-02-04 14-07-30
Screenshot from 2022-02-04 14-07-25
Screenshot from 2022-02-04 14-07-14
Screenshot from 2022-02-04 14-07-06
Screenshot from 2022-02-04 14-07-01
Screenshot from 2022-02-04 14-06-54
Screenshot from 2022-02-04 14-06-40

Mobile Web

Desktop

iOS

Android

@sobitneupane sobitneupane requested a review from a team as a code owner February 4, 2022 08:43
@MelvinBot MelvinBot requested review from mountiny and rushatgabhane and removed request for a team February 4, 2022 08:43
@rushatgabhane

rushatgabhane commented Feb 4, 2022

Copy link
Copy Markdown
Member

would like to request reviewer to double check on Desktop App as I don't have access to macOS

@sobitneupane That's alright for this PR I've added screenshots for desktop.

But FYI, tests on all platforms will be mandatory for any future PRs.
So I'd suggest that you get access to MacOS with the help of this document, VMs, Macbook air etc.

image
Screen Shot 2022-02-04 at 2 35 52 PM

@rushatgabhane

Copy link
Copy Markdown
Member

@sobitneupane One last thing, can you please modify the tests and qa to be more aligned with the issue?
Use the original issue for reference. Cheers.

@sobitneupane

Copy link
Copy Markdown
Contributor Author

@sobitneupane One last thing, can you please modify the tests and qa to be more aligned with the issue? Use the original issue for reference. Cheers.

Updated.

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Tests well on web (chrome and safari xD) and desktop.
Tested mobile for any crashes.

cc: @mountiny

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job everyone! Thank you!

@mountiny mountiny merged commit 8e6e31a into Expensify:main Feb 6, 2022
@OSBotify

OSBotify commented Feb 6, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.37-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants