Use 'Collect' pricing for reporting upgrade path#75594
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ShridharGoel Pls fix the failed checks |
|
@dukenv0307 Updated, but still need to get the info on how to create a free policy (or some way to test this). |
|
@ShridharGoel can you please merge main? I think we can mock the data to show this page |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-21.at.23.30.25.moviOS: HybridAppScreen.Recording.2025-11-21.at.23.30.37.mov |
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
|
@ShridharGoel kindly bump |
|
Merged main |
|
@ShridharGoel pls complete the checklist |
|
@dukenv0307 I had tried mocking a free policy but it hadn't worked. Do you know any way? |
|
@ShridharGoel I think you can try to hard-code to navigate to App/src/components/ReportActionItem/MoneyRequestView.tsx Lines 779 to 782 in ae86bcb |
|
Ok thanks, will try that. I was trying to mock the Onyx values earlier. |
|
@dukenv0307 Updated. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.2.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀
|




Explanation of Change
Use 'Collect' pricing for reporting upgrade path.
Fixed Issues
$ #75340
PROPOSAL: #75340 (comment)
Tests
Be on a free plan.
Create an expense in a report.
Go the expense details.
Click on the "Report" menu item.
Check the amount shown in the upgrade RHP.
Verify that no errors appear in the JS console
Offline tests
QA Steps
Same.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop