Skip to content

[CP Staging] Revert "Add loading UI for search page menu + default to approve section for admins"#75650

Merged
grgia merged 3 commits into
mainfrom
revert-72034-approveSubmit
Nov 20, 2025
Merged

[CP Staging] Revert "Add loading UI for search page menu + default to approve section for admins"#75650
grgia merged 3 commits into
mainfrom
revert-72034-approveSubmit

Conversation

@Beamanator

@Beamanator Beamanator commented Nov 20, 2025 •
edited by grgia
Loading

Copy link
Copy Markdown
Contributor

@Beamanator Beamanator requested review from a team as code owners November 20, 2025 10:25
@melvin-bot melvin-bot Bot requested review from chiragsalian and joekaufmanexpensify and removed request for a team November 20, 2025 10:25
@melvin-bot

melvin-bot Bot commented Nov 20, 2025

Copy link
Copy Markdown

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

🚧 @Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Nov 20, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/Search/index.tsx 0.00% <ø> (ø)
src/hooks/useSearchTypeMenuSections.ts 85.71% <100.00%> (-2.17%) ⬇️
src/hooks/useSearchTypeMenu.tsx 0.00% <0.00%> (ø)
src/pages/Search/SearchTypeMenu.tsx 0.00% <0.00%> (ø)
... and 19 files with indirect coverage changes

@grgia

grgia commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

why lint

@github-actions

github-actions Bot commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #75650.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/75650/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/75650/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/75650/NewExpensify.dmg https://75650.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@Beamanator

Beamanator commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

Testing well! Let's get this merged & CP'd!

grgia
grgia previously approved these changes Nov 20, 2025
View reviewed changes
grgia
grgia previously approved these changes Nov 20, 2025
View reviewed changes
@grgia grgia changed the title Revert "Add loading UI for search page menu + default to approve section for admins" [CP stagingRevert "Add loading UI for search page menu + default to approve section for admins" Nov 20, 2025
@grgia grgia changed the title [CP stagingRevert "Add loading UI for search page menu + default to approve section for admins" [CP Staging] Revert "Add loading UI for search page menu + default to approve section for admins" Nov 20, 2025
luacmartins
luacmartins previously approved these changes Nov 20, 2025
View reviewed changes
@Beamanator Beamanator dismissed stale reviews from luacmartins and grgia via eede7dd November 20, 2025 16:00
@grgia grgia merged commit c68cfe8 into main Nov 20, 2025
28 of 34 checks passed
@grgia grgia deleted the revert-72034-approveSubmit branch November 20, 2025 16:13
@melvin-bot

melvin-bot Bot commented Nov 20, 2025

Copy link
Copy Markdown

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Nov 20, 2025
@grgia grgia removed the Emergency label Nov 20, 2025
@grgia

grgia commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

didn't need to wait for lint on revert

@os-botify os-botify Bot mentioned this pull request Nov 20, 2025
Merged
52 tasks
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 20, 2025
@OSBotify

OSBotify commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

grgia added a commit that referenced this pull request Nov 20, 2025
@grgia
Merge pull request #75650 from Expensify/revert-72034-approveSubmit
4345966 
[CP Staging] Revert "Add loading UI for search page menu + default to approve section for admins"

(cherry picked from commit c68cfe8)

(cherry-picked to staging by georgia)
grgia added a commit that referenced this pull request Nov 20, 2025
@grgia
Merge pull request #75685 from Expensify/cherry-pick-staging-75650-19…
ccbba1a 
…543630625-1

🍒 Cherry pick PR #75650 to staging 🍒
@OSBotify OSBotify mentioned this pull request Nov 20, 2025
Closed
57 tasks
@OSBotify

OSBotify commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.2.61-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@m-natarajan

m-natarajan commented Nov 20, 2025

Copy link
Copy Markdown

Not repro due to revert of the feature, Mac 15.6.1 Chrome, build 9.2.61-3

Repro.2.2.mp4

@OSBotify

OSBotify commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.2.61-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.2.62-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@ZhenjaHorbach ZhenjaHorbach mentioned this pull request Nov 25, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grgia grgia grgia approved these changes

@luacmartins luacmartins luacmartins left review comments

@joekaufmanexpensify joekaufmanexpensify Awaiting requested review from joekaufmanexpensify

@chiragsalian chiragsalian Awaiting requested review from chiragsalian

Assignees

@Beamanator Beamanator

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Beamanator @grgia @OSBotify @m-natarajan @luacmartins