Skip to content

Fix: Scrollbar on the ReportSettings Page#7568

Merged
puneetlath merged 1 commit into
Expensify:mainfrom
parasharrajat:RoomSettingsPage
Feb 4, 2022
Merged

Fix: Scrollbar on the ReportSettings Page#7568
puneetlath merged 1 commit into
Expensify:mainfrom
parasharrajat:RoomSettingsPage

Conversation

@parasharrajat

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #7544

Tests | QA Steps

  1. Open any Room Chat.
  2. Click on the Room title on the header.
  3. Go to Settings on the Room details screen.
  4. Observe that the scrollbar is shown at the edge of the screen. (To test this you will need a device where the content is scrollable. which is difficult to get for native so Please resize vertically the Desktop/Web browser to test this.)
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

iOS

posting shortly...

Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner February 4, 2022 18:31
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team February 4, 2022 18:31
@puneetlath puneetlath merged commit 7c5cd0f into Expensify:main Feb 4, 2022
@OSBotify

OSBotify commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.37-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants