Fix billable and reimbursable update system message is not translated#75717
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-21.at.11.33.35.movAndroid: mWeb ChromeScreen.Recording.2025-11-21.at.11.30.49.moviOS: HybridAppScreen.Recording.2025-11-21.at.11.32.15.moviOS: mWeb SafariScreen.Recording.2025-11-21.at.11.29.34.movMacOS: Chrome / SafariScreen.Recording.2025-11-21.at.11.28.11.movMacOS: DesktopScreen.Recording.2025-11-21.at.11.22.45.mov |
chuckdries
left a comment
There was a problem hiding this comment.
Works as described! Nice
|
Not sure if product sign off is strictly necessary for a localization change but I'm a bit of a rule follower so we'll wait for @heyjennahay to approve before we merge. The change here is specifically adding translation for the word "reimbursable" and "not reimbursable" in the system message
|
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.63-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀
|

Explanation of Change
We just show the reimbursable and billable previous and new value as it is. This PR translates it.
Fixed Issues
$ #75283
PROPOSAL: #75283 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Pre-condition:
Set Language to French
Have a workspace with Rules enabled
Go to workspace settings > Rules
Press Billable default
Set to Billable
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4