fix: workspace chat in the LHN shows as unread after creating an empty report#75724
Merged
Gonals merged 2 commits intoNov 25, 2025
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Author
|
@rojiphil The PR is ready! |
joekaufmanexpensify
approved these changes
Nov 21, 2025
joekaufmanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Fine from a product perspective
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp75724-android-hybrid-001.mp4Android: mWeb Chrome75724-mweb-chrome-001.mp4iOS: HybridApp75724-ios-hybrid-001.mp4iOS: mWeb Safari75724-mweb-safari-001.mp4MacOS: Chrome / Safari75724-web-chrome-001.mp4MacOS: Desktop75724-desktop-001.mp4 |
rojiphil
approved these changes
Nov 22, 2025
rojiphil
left a comment
Contributor
There was a problem hiding this comment.
Thanks @linhvovan29546 for the PR.
@Gonals Changes LGTM and works well too.
All yours. Thanks.
Gonals
approved these changes
Nov 25, 2025
70 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.64-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR removes the lastVisibleActionCreated optimistic data to match the backend. This ensures the workspace chat in the LHN does not appear as unread after creating an empty report in offline mode.
Fixed Issues
$ #65617
PROPOSAL: #65617 (comment)
Tests
Precondition:
Offline tests
Same as test above
QA Steps
Same as test above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-11-21.at.17.32.35.mov
Android: mWeb Chrome
Screen.Recording.2025-11-21.at.17.33.19.mov
iOS: Native
Screen.Recording.2025-11-21.at.17.25.02.mov
iOS: mWeb Safari
Screen.Recording.2025-11-21.at.17.25.25.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-21.at.17.13.06.mov
MacOS: Desktop