[No QA] Update links for Global Reimbursements section#75784
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| @@ -21,11 +21,11 @@ To get started, select from the instructions below. Setup steps vary by currency | |||
| # Choose Your Location | |||
There was a problem hiding this comment.
AI Readiness - Vague heading: The heading "Choose Your Location" lacks feature context. Consider changing to "Choose Your Location for Global Reimbursement Setup" to make it more descriptive for AI understanding and search.
| - 🇬🇧 [Global Reimbursements - United Kingdom] | ||
| - 🇪🇺 [Global Reimbursements - Europe] | ||
| - 🇦🇺 [Global Reimbursements - Australia] | ||
| - 🇺🇸 [Global Reimbursements - U.S.](https://help.expensify.com/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-States) |
There was a problem hiding this comment.
Link formatting improvement: Good fix! The full URL format is correct. Consider if relative links like [Global Reimbursements - U.S.](Global-Reimbursement-United-States) would work better for maintainability, as they would still work if the domain changes. However, full URLs are acceptable if that's the standard for this documentation.
| - 🇪🇺 [Global Reimbursements - Europe] | ||
| - 🇦🇺 [Global Reimbursements - Australia] | ||
| - 🇺🇸 [Global Reimbursements - U.S.](https://help.expensify.com/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-States) | ||
| - 🇨🇦 [Global Reimbursements - Canada](https://help.expensify.com/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Canada) |
There was a problem hiding this comment.
Link formatting: URL format looks correct. Minor note: ensure consistency in whether links use hyphens or spaces in the path structure across all HelpDot articles.
HelpDot Documentation ReviewOverall AssessmentThis PR fixes a critical documentation issue by converting incomplete reference-style markdown links to inline links with full URLs. The changes enable proper navigation from the global reimbursement overview page to country-specific setup guides. Scores Summary
Key FindingsPositive Aspects:
Technical Correctness:
Impact:
Recommendations✅ Approve - This PR should be merged immediately. This is a straightforward, low-risk documentation fix that resolves broken navigation. The changes are:
Files Reviewed
Overall Score: 9.7/10 - Excellent fix that restores critical navigation functionality. |
|
A preview of your ExpensifyHelp changes have been deployed to https://cbadfacf.helpdot.pages.dev ⚡️ Updated articles: |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.2.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
It was called out here, that the links in this article didn't point to the downstream articles. I've updated that now.
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop