fix: infinite loading appears when logging in via hellogorgeous link#75808
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppUploading 20251207155409206.mp4… Android: mWeb Chrome20251207154440140.mp4iOS: HybridAppiOS: mWeb Safari20251207154243199.mp4MacOS: Chrome / Safari20251129042935302.mp420251129042554958.mp420251207154012058.mp4 |
|
@paulnjs Could you please update the expected behavior?
|
|
@ahmedGaber93 updated. Thank you |
|
Bug: mWeb and native apps (Small screens) - Infinite loading screen appears after navigating back from Concierge chat Steps
There is an infinite loading screen after navigating back from Concierge chat Videos20251129044320476.mp420251129054102511.mp420251129053228324.mp4 |
JmillsExpensify
left a comment
There was a problem hiding this comment.
This looks good from a product perspective.
Verify the app redirects to your most recently accessed report (or the Concierge report for new users), rather than getting stuck in an infinite loading state.
I'm still investigating to fix this issue |
|
@ahmedGaber93 Could you help to check with the new code changes? Screen.Recording.2025-12-03.at.22.57.00.mov |
|
@aldo-expensify I approved this PR, but since I was removed from GitHub auto-assignment due to being OOO for the next 3 weeks starting tomorrow, my approval didn’t trigger a request for your review. Changes and results LGTM! All yours! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.2.89-1 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.89-6 🚀
|
Explanation of Change
Fixed Issues
$#73506
PROPOSAL:#73506 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2025-11-22.at.10.33.56.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2025-11-22.at.10.28.00.mov
MacOS: Chrome / Safari
chorme.mov
MacOS: Desktop
Screen.Recording.2025-11-22.at.10.47.29.mov