[No QA] Handle `chatReportIDAdmins` and `chatReportIDAnnounce` as string instead of number by rayane-d · Pull Request #75814 · Expensify/App

rayane-d · 2025-11-22T10:32:14Z

Explanation of Change

Web-E PR:

https://github.com/Expensify/Web-Expensify/pull/49569

Auth PR:

https://github.com/Expensify/Auth/pull/18765

Fixed Issues

$ #71326
PROPOSAL:

Tests

Test 1: Report Action Avatars in Policy Chat Rooms

Scenario 1A: Workspace with Announce Room (3+ members)

Log in as a workspace admin where the workspace has 3 or more members
Navigate to the #announce room for that workspace
Look at any message in the chat
Verify the avatar(s) display correctly next to messages

Expected: Avatars render without errors; no console errors about invalid Onyx keys

Scenario 1B: Workspace without Announce Room (1-2 members)

Log in as admin of a workspace with only 1-2 members (no announce room exists)
Navigate to the #admins room
Look at any message in the chat
Verify avatars display correctly

Expected: Since chatReportIDAnnounce is "0", it should fall back to chatReportIDAdmins; avatars render correctly
Expected: No Onyx errors or console errors related to chatReportIDAnnounce or chatReportIDAdmins

Test 2: Create New Workspace

Log in to the app
Go to Workspaces -> New workspace
Create a workspace
Complete the workspace creation flow
After creation, navigate to the new workspace's #admins room

Expected:

Workspace creates successfully
#admins room is accessible and loads correctly
Expected: No Onyx errors or console errors related to chatReportIDAnnounce or chatReportIDAdmins
No API errors during creation

Test 3: Create Draft Workspace

Go offline
Create a workspace

Expected: No Onyx-related errors or console errors

Test 4: Workspace Admin Restricted Action

Prerequisites: remove this code:

App/src/pages/RestrictedAction/Workspace/WorkspaceRestrictedActionPage.tsx

Lines 24 to 28 in e0923e0

    
           // Workspace Owner 
        
           if (PolicyUtils.isPolicyOwner(policy, session?.accountID ?? -1)) { 
        
               return <WorkspaceOwnerRestrictedAction />; 
        
           }

Log in as a workspace admin
Open https://dev.new.expensify.com:8082/restricted-action/workspace/
When the restricted action modal/page appears, click the button to "Chat in #admins"

Expected:

Navigation to the #admins room works correctly
URL shows a valid report ID
The correct #admins room loads
No Onyx errors or console errors related to chatReportIDAnnounce or chatReportIDAdmins

Test 5: Policy Accounting Page - Onboarding Specialist Link

Log in as an admin of at least one workspace
Go to the workspace setting > new features > enable accounting
Remove !!account?.guideDetails?.email && from the condition here:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Line 611 in e0923e0

{!!account?.guideDetails?.email && !hasAccountingConnections(policy) && (
Look for the footer message that references admin chat
Click on the "Chat with your setup specialist." link

Expected:

Navigation to the #admins room works correctly
URL shows a valid report ID
The correct #admins room loads
No Onyx errors or console errors related to chatReportIDAnnounce or chatReportIDAdmins

Test 6: Subscription Settings

Log in as an admin of a workspace
Change the workspace plan to "Control"
Navigate to Workspace Settings -> Subscription
Click on "Subscription settings"
Click on the "#admins room" link

Expected:

Navigation to the #admins room works correctly
URL shows a valid report ID
The correct #admins room loads
No Onyx errors or console errors related to chatReportIDAnnounce or chatReportIDAdmins

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Regression tests related to the creation of the #admin and #announce workspace chat rooms, their links, and report action avatars within them.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-11-22T10:32:40Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-22T10:40:14Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ents/ReportActionAvatars/useReportActionAvatars.ts	`88.63% <100.00%> (ø)`
src/libs/actions/Policy/Policy.ts	`33.82% <100.00%> (-0.33%)`	⬇️
src/libs/migrateOnyx.ts	`100.00% <100.00%> (ø)`
...ction/Workspace/WorkspaceAdminRestrictedAction.tsx	`0.00% <ø> (ø)`
...ages/home/report/SystemChatReportFooterMessage.tsx	`6.66% <0.00%> (ø)`
...Subscription/SubscriptionSettings/index.native.tsx	`0.00% <0.00%> (ø)`
...ttings/Subscription/SubscriptionSettings/index.tsx	`0.00% <0.00%> (ø)`
...ages/workspace/accounting/PolicyAccountingPage.tsx	`0.00% <0.00%> (ø)`
...s/migrations/ConvertPolicyChatReportIDsToString.ts	`41.17% <41.17%> (ø)`
... and 11 files with indirect coverage changes

…ead of number

heyjennahay · 2025-11-27T15:43:25Z

No product change. Removing myself and unsubscribing

grgia

Code is LGTM here @rayane-d

…ersion. Updated the types for backward compatibility.

melvin-bot · 2025-12-15T22:46:29Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-d · 2025-12-16T21:14:16Z

@jjcoffee - whenever you'd like to test these changes against the backend changes (which are currently on hold on this App PR), please feel free to DM me and I'd be happy to share an ngrok URL for testing

rayane-d · 2025-12-17T13:45:46Z

Update: I've sent the ngrok URL to Joel so we can test these changes both with and without the BE PRs

jjcoffee · 2025-12-17T14:22:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-2025-12-17_16.24.41.mp4

Android: mWeb Chrome

android-chrome-2025-12-17_16.32.15.mp4

iOS: HybridApp

ios-app-2025-12-17_17.31.57.mp4

iOS: mWeb Safari

Uploading ios-safari-2025-12-17_17.31.59.mp4…

MacOS: Chrome / Safari

Without BE PRs

desktop-chrome-2025-12-17_15.28.13.mp4

With BE PRs

desktop-chrome-2025-12-17_17.04.21.mp4

jjcoffee

LGTM! Tests well 🙏

rayane-d · 2025-12-17T16:43:16Z

Resolved merge conflicts

tgolen · 2025-12-17T17:00:46Z


-        /** ReportID of the admins room for this workspace */
-        chatReportIDAdmins?: number;
+        /** ReportID of the admins room for this workspace - This should be a string, we are keeping the number for backward compatibility */


How long do we need to keep it as a number? Can we use an onyx migration to clean up the existing data and then remove the migration after a month, and then set this type to only be a string?

Ah, I wasn't aware we had a mechanism to migrate Onyx data - thanks for pointing that out. That approach sounds good to me 👍

Added an onyx migration: #75814 (comment)

rayane-d · 2025-12-23T23:21:26Z

Sorry for the delay - I was handling higher-priority tasks and then was out sick. I'm catching up now.

…cy chat reports report IDs from number to string

rayane-d · 2025-12-24T00:22:00Z

Onyx migration result:

Before:

After:

Logs:

rayane-d · 2025-12-24T00:26:23Z

Updated

tgolen

Thanks for adding the migration!

OSBotify · 2025-12-29T17:24:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-30T15:19:20Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.2.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-31T18:33:16Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.89-6 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

clean up unecessary toString conversions

626c760

melvin-bot Bot assigned rayane-d Nov 22, 2025

rayane-d requested a review from grgia November 22, 2025 10:32

rayane-d marked this pull request as ready for review November 22, 2025 10:32

rayane-d requested review from a team as code owners November 22, 2025 10:32

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team November 22, 2025 10:32

melvin-bot Bot requested review from heyjennahay and removed request for a team November 22, 2025 10:32

rayane-d removed the request for review from ZhenjaHorbach November 22, 2025 10:32

github-actions Bot reviewed Nov 22, 2025

View reviewed changes

Comment thread src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

github-actions Bot reviewed Nov 22, 2025

View reviewed changes

Comment thread src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx

rayane-d changed the title ~~[No QA] Clean up unnecessary toString reportID conversions~~ [No QA] Handle chatReportIDAdmins and chatReportIDAnnounce as string instead of number Nov 22, 2025

Handle chatReportIDAdmins and chatReportIDAnnounce as string inst…

359b4b0

…ead of number

rayane-d marked this pull request as draft November 22, 2025 11:44

rayane-d mentioned this pull request Nov 22, 2025

[Due for payment 2026-01-07] Ensure All ReportIDs are string #71326

Closed

2 tasks

heyjennahay removed their request for review November 27, 2025 15:43

grgia reviewed Dec 12, 2025

View reviewed changes

rayane-d added 8 commits December 12, 2025 22:49

Merge branch 'Expensify:main' into string-reportID

da11410

Refactor chatReportIDAdmins handling to ensure consistent string conv…

c8524fe

…ersion. Updated the types for backward compatibility.

fix lint error

0c60629

Merge branch 'Expensify:main' into string-reportID

4315f4b

handle '0' id

cb4cdbb

prettier

32a38bb

Merge branch 'Expensify:main' into string-reportID

9982ad5

Merge branch 'Expensify:main' into string-reportID

c213a23

melvin-bot Bot removed the request for review from a team December 15, 2025 22:46

rayane-d marked this pull request as draft December 15, 2025 22:49

rayane-d marked this pull request as ready for review December 15, 2025 23:21

rayane-d added 2 commits December 16, 2025 00:24

Merge branch 'Expensify:main' into string-reportID

6bd7bf4

Merge branch 'Expensify:main' into string-reportID

2498795

jjcoffee approved these changes Dec 17, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia December 17, 2025 16:38

Merge branch 'main' into string-reportID

93dba47

rayane-d requested a review from tgolen December 17, 2025 16:46

tgolen requested changes Dec 17, 2025

View reviewed changes

rayane-d added 2 commits December 24, 2025 00:40

address review comments

4d1efec

Add ConvertPolicyChatReportIDsToString Onyx migration to convert poli…

437f324

…cy chat reports report IDs from number to string

rayane-d commented Dec 24, 2025

View reviewed changes

Fix optional chaining for chatReportIDAdmins in PolicyAccountingPage

272742a

rayane-d requested a review from tgolen December 24, 2025 00:25

Merge branch 'Expensify:main' into string-reportID

ea204c5

tgolen approved these changes Dec 29, 2025

View reviewed changes

tgolen merged commit ba1192d into Expensify:main Dec 29, 2025
30 checks passed

OSBotify mentioned this pull request Dec 30, 2025

Deploy Checklist: New Expensify 2025-12-30 #78583

Closed

56 tasks

rayane-d deleted the string-reportID branch April 23, 2026 23:04

	// Workspace Owner
	if (PolicyUtils.isPolicyOwner(policy, session?.accountID ?? -1)) {
	return <WorkspaceOwnerRestrictedAction />;
	}

Conversation

rayane-d commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 22, 2025

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Nov 22, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

heyjennahay commented Nov 27, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Dec 15, 2025

Uh oh!

rayane-d commented Dec 16, 2025

Uh oh!

rayane-d commented Dec 17, 2025

Uh oh!

jjcoffee commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgolen Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Dec 23, 2025

Uh oh!

rayane-d Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Onyx migration result:

Before:

After:

Logs:

Uh oh!

rayane-d commented Dec 24, 2025

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 29, 2025

Uh oh!

OSBotify commented Dec 30, 2025

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

rayane-d commented Nov 22, 2025 •

edited

Loading

codecov Bot commented Nov 22, 2025 •

edited by github-actions Bot

Loading

jjcoffee commented Dec 17, 2025 •

edited

Loading

rayane-d Dec 24, 2025 •

edited

Loading