[NO QA] chore(deps): bump eslint-config-expensify to 2.0.99 by gelocraft · Pull Request #75887 · Expensify/App

gelocraft · 2025-11-24T11:36:03Z

Explanation of Change

bump eslint-config-expensify to 2.0.99
add inline disables for remaining unicorn/no-array-for-each violations (will be fixed in my follow-up PRs)

Fixed Issues

$ #67422
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-11-24T11:36:10Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-11-24T11:36:13Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2025-11-24T11:49:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyReportHeader.tsx	`0.17% <ø> (ø)`
src/components/OptionListContextProvider.tsx	`53.65% <ø> (ø)`
src/components/SettlementButton/index.tsx	`0.38% <ø> (ø)`
src/hooks/useCardFeeds.tsx	`58.33% <ø> (ø)`
src/hooks/useDuplicateTransactionsAndViolations.ts	`28.57% <ø> (ø)`
src/libs/CardFeedUtils.ts	`89.32% <ø> (ø)`
src/libs/CategoryOptionListUtils.ts	`95.50% <ø> (ø)`
src/libs/EmojiTrie.ts	`100.00% <ø> (ø)`
...ion/AppNavigator/usePreloadFullScreenNavigators.ts	`17.24% <ø> (ø)`
...c/libs/Navigation/linkingConfig/RELATIONS/index.ts	`100.00% <ø> (ø)`
... and 25 more
... and 8 files with indirect coverage changes

gelocraft · 2025-11-24T12:04:44Z

+    // eslint-disable-next-line rulesdir/no-default-id-values
    const policyID = policy?.id ?? '-1';


This unrelated Changed files ESLint check error happens when I add unicorn/no-array-for-each inline disable to this file.

I disabled this error because I’m not sure how to address them.

changed files error log

Error: 21:32 error Do not default string IDs to any value. See: https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-IDs rulesdir/no-default-id-values

Did you read the documentation at https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-IDs ? I think it's pretty clear. Remove the ?? '-1' and update subsequent uses to correctly account for policyID being potentially undefined.

thanks for helping

gelocraft · 2025-11-24T12:05:29Z

+// eslint-disable-next-line no-restricted-syntax
 import * as ErrorUtils from '@libs/ErrorUtils';


This unrelated Changed files ESLint check error happens when I add unicorn/no-array-for-each inline disable to this file.

I disabled this error because I’m not sure how to address them.

changed files error log

Error: 8:8 error Namespace imports from @libs are not allowed. Use named imports instead. Example: import { method } from "@libs/module" no-restricted-syntax

I personally really dislike this lint rule, but we should fix it rather than disabling it. You need to look at usages of ErrorUtils in this file, destructure all the imports that are used in this file, and then remove the ErrorUtils. prefix from all usages.

thanks for helping.

done destructuring methods of ErrorUtils

gelocraft · 2025-11-24T12:23:02Z

@roryabraham ready for review

roryabraham · 2025-11-24T22:41:31Z

+// eslint-disable-next-line no-restricted-syntax
 import * as ErrorUtils from '@libs/ErrorUtils';


I personally really dislike this lint rule, but we should fix it rather than disabling it. You need to look at usages of ErrorUtils in this file, destructure all the imports that are used in this file, and then remove the ErrorUtils. prefix from all usages.

roryabraham · 2025-11-24T22:43:52Z

+    // eslint-disable-next-line rulesdir/no-default-id-values
    const policyID = policy?.id ?? '-1';


Did you read the documentation at https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-IDs ? I think it's pretty clear. Remove the ?? '-1' and update subsequent uses to correctly account for policyID being potentially undefined.

roryabraham · 2025-11-25T00:26:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-11-25T00:32:21Z

Congrats, that's your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It's an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2025-11-25T00:58:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-26T03:54:43Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-27T01:22:59Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

gelocraft requested review from a team as code owners November 24, 2025 11:36

melvin-bot Bot assigned gelocraft Nov 24, 2025

melvin-bot Bot requested review from heyjennahay and shubham1206agra and removed request for a team November 24, 2025 11:36

melvin-bot Bot removed the request for review from a team November 24, 2025 11:36

gelocraft mentioned this pull request Nov 24, 2025

[$250] Enable no-array-for-each lint rule #67422

Closed

gelocraft changed the title ~~chore(deps): bump eslint-config-expensify to 2.0.99~~ [NO QA] chore(deps): bump eslint-config-expensify to 2.0.99 Nov 24, 2025

gelocraft commented Nov 24, 2025

View reviewed changes

roryabraham requested changes Nov 24, 2025

View reviewed changes

gelocraft force-pushed the bump-eslint-config-expensify branch from 5cd36f0 to 50ce0f0 Compare November 24, 2025 23:18

gelocraft commented Nov 24, 2025

View reviewed changes

Comment thread src/pages/workspace/accounting/intacct/SageIntacctEntityPage.tsx Outdated

gelocraft requested a review from roryabraham November 24, 2025 23:52

gelocraft added 7 commits November 25, 2025 00:01

chore(deps): bump eslint-config-expensify

7c48a02

chore(eslint): temporarily add inline disables

d0a86f2

ci: run gh-actions-build

a0b2dc1

fix(eslint): disable unrelated errors

c123758

refactor: destructure ErrorUtils

9951e9d

fix(eslint): rulesdir/no-default-id-values

a8e0774

refactor(updateSageIntacctEntity): change policyID type signature

7919425

gelocraft force-pushed the bump-eslint-config-expensify branch from 50ce0f0 to 7919425 Compare November 25, 2025 00:06

roryabraham approved these changes Nov 25, 2025

View reviewed changes

roryabraham merged commit 13b7ba0 into Expensify:main Nov 25, 2025
39 of 41 checks passed

OSBotify mentioned this pull request Nov 26, 2025

Deploy Checklist: New Expensify 2025-11-26 #76071

Closed

70 tasks

gelocraft deleted the bump-eslint-config-expensify branch November 26, 2025 03:16

		// eslint-disable-next-line rulesdir/no-default-id-values
		const policyID = policy?.id ?? '-1';

		// eslint-disable-next-line no-restricted-syntax
		import * as ErrorUtils from '@libs/ErrorUtils';

Conversation

gelocraft commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

codecov Bot commented Nov 24, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gelocraft Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

gelocraft Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

gelocraft Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

gelocraft Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

gelocraft commented Nov 24, 2025

Uh oh!

roryabraham Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roryabraham commented Nov 25, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot Bot commented Nov 25, 2025

Uh oh!

OSBotify commented Nov 25, 2025

Uh oh!

OSBotify commented Nov 26, 2025

Uh oh!

OSBotify commented Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gelocraft commented Nov 24, 2025 •

edited

Loading

codecov Bot commented Nov 24, 2025 •

edited by github-actions Bot

Loading

gelocraft Nov 24, 2025 •

edited

Loading

gelocraft Nov 24, 2025 •

edited

Loading