Skip to content

[NO QA] Resolve broken and flakey tests #75932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 3 commits into from
Nov 24, 2025
Merged

[NO QA] Resolve broken and flakey tests #75932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb18907
Add missing useNavigation mock to BaseSelectionListSectionsTest
Julesssss Nov 24, 2025
c5da3cd
Fix flaky test by using specific action type instead of random
Julesssss Nov 24, 2025
b011b7e
Update useNavigation mock to return isFocused method
Julesssss Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/unit/BaseSelectionListSectionsTest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ jest.mock('@react-navigation/native', () => {
...actualNav,
useIsFocused: jest.fn(),
useFocusEffect: jest.fn(),
useNavigation: jest.fn(() => ({
isFocused: jest.fn(() => true),
})),
};
});

Expand Down
15 changes: 12 additions & 3 deletions tests/unit/OptionsListUtilsTest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,10 @@ describe('OptionsListUtils', () => {
// Given a report without reportID (so it uses the lastReportAction)
const report: Report | undefined = undefined;
const lastActorDetails = PERSONAL_DETAILS['3'];
const lastAction = createRandomReportAction(1);
const lastAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT,
};

// When we call shouldShowLastActorDisplayName with all valid conditions
const result = shouldShowLastActorDisplayName(report, lastActorDetails, lastAction);
Expand All @@ -1406,7 +1409,10 @@ describe('OptionsListUtils', () => {
// Given a report without reportID (so it uses the lastReportAction)
const report: Report | undefined = undefined;
const lastActorDetails = PERSONAL_DETAILS['2'];
const lastAction = createRandomReportAction(1);
const lastAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT,
};

const result = shouldShowLastActorDisplayName(report, lastActorDetails, lastAction);
expect(result).toBe(true);
Expand All @@ -1417,7 +1423,10 @@ describe('OptionsListUtils', () => {
// Given a report without reportID
const report: Report | undefined = undefined;
const lastActorDetails = PERSONAL_DETAILS['2'];
const lastAction = createRandomReportAction(1);
const lastAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT,
};

// When we call shouldShowLastActorDisplayName with the current user as last actor
const result = shouldShowLastActorDisplayName(report, lastActorDetails, lastAction);
Expand Down
Loading