Skip to content

[NoQA] Fix lint on main #76007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Nov 25, 2025
Merged

[NoQA] Fix lint on main #76007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/libs/ReportLayoutUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,18 @@ function groupTransactionsByCategory(transactions: Transaction[], report: OnyxEn

const groups = new Map<string, Transaction[]>();

transactions.forEach((transaction) => {
for (const transaction of transactions) {
const category = getCategory(transaction);
const categoryKey = category || '';

if (!groups.has(categoryKey)) {
groups.set(categoryKey, []);
}
groups.get(categoryKey)?.push(transaction);
});
}

const result: GroupedTransactions[] = [];
groups.forEach((transactionList, categoryKey) => {
for (const [categoryKey, transactionList] of groups) {
// Translation handled at component level
const displayName = categoryKey;

Expand All @@ -47,7 +47,7 @@ function groupTransactionsByCategory(transactions: Transaction[], report: OnyxEn
totalAmount,
isExpanded: true,
});
});
}

// Sort alphabetically (A→Z), empty keys (uncategorized) at the end
return result.sort((a, b) => {
Expand All @@ -72,18 +72,18 @@ function groupTransactionsByTag(transactions: Transaction[], report: OnyxEntry<R

const groups = new Map<string, Transaction[]>();

transactions.forEach((transaction) => {
for (const transaction of transactions) {
const tag = getTag(transaction);
const tagKey = tag || '';

if (!groups.has(tagKey)) {
groups.set(tagKey, []);
}
groups.get(tagKey)?.push(transaction);
});
}

const result: GroupedTransactions[] = [];
groups.forEach((transactionList, tagKey) => {
for (const [tagKey, transactionList] of groups) {
// Translation handled at component level
const displayName = tagKey;

Expand All @@ -103,7 +103,7 @@ function groupTransactionsByTag(transactions: Transaction[], report: OnyxEntry<R
totalAmount,
isExpanded: true,
});
});
}

// Sort alphabetically (A→Z), empty keys (untagged) at the end
return result.sort((a, b) => {
Expand Down
Loading