Skip to content

[No QA][Sentry] Finish navigation spans when empty results #76030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 4 commits into from
Nov 25, 2025
Merged

[No QA][Sentry] Finish navigation spans when empty results #76030

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
051cd03
Cancel navigation span when empty result
sosek108 Nov 25, 2025
5f8bf50
prettier fix
sosek108 Nov 25, 2025
198b920
add cancel also when hasErrors is true
sosek108 Nov 25, 2025
6b1f523
add cancel also when hasErrors is true
sosek108 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/Search/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ import {
shouldShowEmptyState,
shouldShowYear as shouldShowYearUtil,
} from '@libs/SearchUIUtils';
import {endSpan, startSpan} from '@libs/telemetry/activeSpans';
import {cancelSpan, endSpan, startSpan} from '@libs/telemetry/activeSpans';
import {isOnHold, isTransactionPendingDelete, mergeProhibitedViolations, shouldShowViolation} from '@libs/TransactionUtils';
import Navigation, {navigationRef} from '@navigation/Navigation';
import type {SearchFullscreenNavigatorParamList} from '@navigation/types';
Expand Down Expand Up @@ -921,11 +921,13 @@ function Search({

if (searchResults === undefined) {
Log.alert('[Search] Undefined search type');
cancelSpan(CONST.TELEMETRY.SPAN_NAVIGATE_TO_REPORTS_TAB);
return <FullPageOfflineBlockingView>{null}</FullPageOfflineBlockingView>;
}

if (hasErrors) {
const isInvalidQuery = searchRequestResponseStatusCode === CONST.JSON_CODE.INVALID_SEARCH_QUERY;
cancelSpan(CONST.TELEMETRY.SPAN_NAVIGATE_TO_REPORTS_TAB);
return (
<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
<FullPageErrorView
Expand All @@ -940,6 +942,7 @@ function Search({

const visibleDataLength = data.filter((item) => item.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline).length;
if (shouldShowEmptyState(isDataLoaded, visibleDataLength, searchResults?.search?.type)) {
cancelSpan(CONST.TELEMETRY.SPAN_NAVIGATE_TO_REPORTS_TAB);
Comment thread
rlinoz marked this conversation as resolved.
return (
<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
<EmptySearchView
Expand Down
Loading