feat: Gather KYB documents when verification fails for USD BA's by MrMuzyk · Pull Request #76033 · Expensify/App

MrMuzyk · 2025-11-25T14:53:23Z

Explanation of Change

Added a new step to USD VBBA flow that is conditionally showed if user failed automated verification

Fixed Issues

$ #75707
PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Testing this requires to have an account that was manually set to a certain state, ie: #75707 (comment)

We will make sure that current functionality works without any issues, ship the new step and look out for regressions - https://expensify.slack.com/archives/C01GTK53T8Q/p1778070528787499?thread_ts=1763989665.580719&cid=C01GTK53T8Q

Offline tests

QA Steps

Verify you can connect USD bank account to USD workspace without any issue

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2025-11-25T14:53:29Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-11-25T15:01:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.79% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/BankAccountUtils.ts	`91.17% <100.00%> (+4.21%)`	⬆️
.../ReimbursementAccount/ReimbursementAccountPage.tsx	`0.00% <ø> (ø)`
src/types/form/ReimbursementAccountForm.ts	`100.00% <ø> (ø)`
src/libs/actions/BankAccounts.ts	`11.26% <0.00%> (-0.08%)`	⬇️
...mentAccount/USD/USDVerifiedBankAccountFlowPage.tsx	`0.00% <0.00%> (ø)`
...es/ReimbursementAccount/USD/KYBDocuments/index.tsx	`0.00% <0.00%> (ø)`
... and 14 files with indirect coverage changes

…07-usd-flow-kyb-files

VickyStash · 2026-06-01T06:58:37Z

@gijoe0295 kind bump here 🙂

gijoe0295 · 2026-06-01T10:30:06Z

I got this issue but don't know if it's just because I mocked the data or a real bug:

Mock the documents step via Onyx and URL
After submitting the docs, the screen is blank

Screen.Recording.2026-06-01.at.17.28.20.mov

gijoe0295 · 2026-06-01T10:35:39Z

@codex Review this

gijoe0295 · 2026-06-01T10:36:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2026-06-05.at.11.08.26.mov

iOS: HybridApp

Screen.Recording.2026-06-05.at.10.59.44.mov

iOS: mWeb Safari

Screen.Recording.2026-06-05.at.11.01.59.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-01.at.17.28.20.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9687c7d8e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

VickyStash · 2026-06-01T15:40:23Z

@madmax330, can you please help with more real-life testing here?

gijoe0295 · 2026-06-02T08:50:56Z

Maxence just helped me create a failed BBA. Testing today

madmax330 · 2026-06-02T18:07:08Z

Alright, I will test tonight

VickyStash · 2026-06-03T15:15:02Z

Note: I'll be OOO tomorrow (national holiday in Poland), back on Friday!

gijoe0295

Small request

gijoe0295 · 2026-06-05T03:18:19Z

    isBankAccountPartiallySetup,
    isPersonalBankAccountMissingInfo,
+    isUserAddressVerificationRequired,
+    isUserDOBVerificationRequired,


Can we add tests for getRequiredKybDocuments?

Done in d338a68

# Conflicts: # cspell.json # src/libs/API/parameters/index.ts # src/libs/API/types.ts

gijoe0295

LGTM

VickyStash · 2026-06-08T12:52:33Z

Kind bump @madmax330 🙂

github-actions · 2026-06-08T17:40:21Z

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-08T17:47:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-08T17:47:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #76033.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-40ebd1b8643-9a6f6b8-3602e308c4b4ac4f56a006977d97af9a194febd2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-40ebd1b-9a6f6b8-7b120f771be3e6088abf98d744c258919f0195b3/index.html

Web 🕸️
https://76033.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-09T04:32:36Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-09T04:36:47Z

Help site review — changes required ✅

This PR adds a new in-app Verification step to the USD verified business bank account flow, shown when automated verification fails. It asks the user to upload only the documents needed for the checks that failed (Tax ID Verification, Name Change Document, Company address verification, Address verification, Date of birth verification), submitted via Choose file → Verify, with a Finish via chat fallback to Concierge.

The existing help article previously framed failed-verification document requests as something Concierge handles via chat. That no longer matches the product, so I updated it.

Draft docs PR: #92996

What I changed in Connect-a-Business-Bank-Account.md

Rewrote the Documentation review item under What to expect after submitting your bank account details to describe the in-app Verification step and its Choose file / Verify / Finish via chat actions.
Expanded the FAQ Why am I asked for documents when adding my bank account? to list the documents that may be requested and how to submit them.
Added retrieval keywords (verification documents, Tax ID Verification, address verification, verification failed, KYB documents).

UI labels were verified against the exact localized strings merged in this PR. This step only renders for accounts that fail automated verification (a manually set account state), so it couldn't be reached in the live UI for screenshots.

⚠️ I applied the HelpDot label but couldn't assign you to the docs PR — MrMuzyk currently has only read access on Expensify/App, which GitHub won't accept as an assignee. You're tagged in the PR body for review instead.

@MrMuzyk, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-06-10T00:35:14Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.1-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MrMuzyk added 2 commits November 25, 2025 08:14

feat: 75707 gather KYB files for USD flow

995b846

feat: step v1

b9d72c4

melvin-bot Bot assigned MrMuzyk Nov 25, 2025

MrMuzyk added 25 commits November 26, 2025 16:17

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

a13dd26

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

6e9db69

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

f6c2536

…07-usd-flow-kyb-files

feat: new step

3f2f902

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

005850b

…07-usd-flow-kyb-files

feat: file types

d5bac0c

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

8fd1cf9

…07-usd-flow-kyb-files

feat: pause

76926e7

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

c8a0677

…07-usd-flow-kyb-files

feat: types

88ab4a4

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

e96c832

…07-usd-flow-kyb-files

feat: submit

f0f4304

fix: checks

6faea26

fix: add kyb param

840da4f

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

208d831

…07-usd-flow-kyb-files

feat: param name

3a4d54d

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

6832d65

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

1f95a69

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

d3d828b

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

d6d6cda

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

e47fa57

…07-usd-flow-kyb-files

fix: can be missing

5b0aaa7

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

f340a97

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

cada552

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

bf5afa5

…07-usd-flow-kyb-files

MrMuzyk mentioned this pull request May 29, 2026

[Due for payment 2026-06-17] Add KYB document uploads when checks fail #75707

Open

gijoe0295 suggested changes Jun 1, 2026

View reviewed changes

Comment thread src/languages/en.ts Outdated

Comment thread src/languages/en.ts Outdated

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread src/pages/ReimbursementAccount/USD/KYBDocuments/index.tsx Outdated

Comment thread src/pages/ReimbursementAccount/USD/USDVerifiedBankAccountFlowPage.tsx

VickyStash added 3 commits June 1, 2026 16:46

Update descriptions

5bf2826

Skip KYB documents step when no documents are required

46bfc03

Fix KYB tax ID upload crash from draft key collision

f9e4c2d

gijoe0295 suggested changes Jun 5, 2026

View reviewed changes

VickyStash added 2 commits June 5, 2026 09:49

Merge branch 'main' into feat/75707-usd-flow-kyb-files

30b9901

# Conflicts: # cspell.json # src/libs/API/parameters/index.ts # src/libs/API/types.ts

Add getRequiredKYBDocuments tests

d338a68

gijoe0295 approved these changes Jun 5, 2026

View reviewed changes

melvin-bot Bot requested a review from madmax330 June 5, 2026 10:33

madmax330 approved these changes Jun 8, 2026

View reviewed changes

madmax330 merged commit 40ebd1b into Expensify:main Jun 8, 2026
35 checks passed

OSBotify mentioned this pull request Jun 9, 2026

Deploy Checklist: New Expensify 2026-06-09 #92988

Closed

MelvinBot mentioned this pull request Jun 9, 2026

[No QA] Docs updates for E/A#76033 KYB verification documents step for USD bank accounts #92996

Merged

Conversation

MrMuzyk commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 25, 2025

Uh oh!

codecov Bot commented Nov 25, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

VickyStash commented Jun 1, 2026

Uh oh!

gijoe0295 commented Jun 1, 2026

Uh oh!

Uh oh!

Uh oh!

gijoe0295 commented Jun 1, 2026

Uh oh!

gijoe0295 commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

VickyStash commented Jun 1, 2026

Uh oh!

gijoe0295 commented Jun 2, 2026

Uh oh!

madmax330 commented Jun 2, 2026

Uh oh!

VickyStash commented Jun 3, 2026

Uh oh!

gijoe0295 left a comment

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

gijoe0295 left a comment

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Jun 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

OSBotify commented Jun 8, 2026

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

MelvinBot commented Jun 9, 2026

Help site review — changes required ✅

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MrMuzyk commented Nov 25, 2025 •

edited

Loading

codecov Bot commented Nov 25, 2025 •

edited by github-actions Bot

Loading

gijoe0295 commented Jun 1, 2026 •

edited

Loading