Skip to content

[CP Staging] Revert "Previous selection is cleared when selecting another member in Expenses From"#76041

Merged
arosiclair merged 1 commit into
mainfrom
revert-75410-fix/74900
Nov 25, 2025
Merged

[CP Staging] Revert "Previous selection is cleared when selecting another member in Expenses From"#76041
arosiclair merged 1 commit into
mainfrom
revert-75410-fix/74900

Conversation

@arosiclair

@arosiclair arosiclair commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Reverts #75410

$ #75951

@arosiclair arosiclair self-assigned this Nov 25, 2025
@arosiclair arosiclair marked this pull request as ready for review November 25, 2025 16:24
@arosiclair arosiclair requested review from a team as code owners November 25, 2025 16:24
@melvin-bot melvin-bot Bot requested review from heyjennahay and lakchote and removed request for a team November 25, 2025 16:24
@melvin-bot

melvin-bot Bot commented Nov 25, 2025

Copy link
Copy Markdown

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@inimaga inimaga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arosiclair arosiclair merged commit 2c9ad8d into main Nov 25, 2025
32 of 36 checks passed
@arosiclair arosiclair deleted the revert-75410-fix/74900 branch November 25, 2025 16:29
@melvin-bot melvin-bot Bot added the Emergency label Nov 25, 2025
@melvin-bot

melvin-bot Bot commented Nov 25, 2025

Copy link
Copy Markdown

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@codecov

codecov Bot commented Nov 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/ApproverSelectionList.tsx 0.00% <0.00%> (ø)
... and 9 files with indirect coverage changes

@arosiclair

Copy link
Copy Markdown
Contributor Author

straight revert

@mountiny mountiny changed the title Revert "Previous selection is cleared when selecting another member in Expenses From" [CP Staging] Revert "Previous selection is cleared when selecting another member in Expenses From" Nov 25, 2025
OSBotify pushed a commit that referenced this pull request Nov 25, 2025
Revert "Previous selection is cleared when selecting another member in Expenses From"

(cherry picked from commit 2c9ad8d)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 25, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.63-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants