Update "Company cards" page copy (when no cards are connected)#76567
Merged
Conversation
melvin-bot
Bot
requested review from
carlosmiceli and
joekaufmanexpensify
and removed request for
a team
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
@carlosmiceli is it easy for you to translate this to Spanish and all the other languages with a command or something? I thought that was possible... |
NikkiWines
requested changes
Dec 2, 2025
NikkiWines
requested changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Also please link to a convo or issue in the Fixed issues portion of the PR description (you can use this link: https://expensify.slack.com/archives/C03SSAQG5/p1764014587436879?thread_ts=1763431093.297579&cid=C03SSAQG5) so we can trace these changes back to particular convos in the future.
NikkiWines
previously requested changes
Dec 2, 2025
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
@jamesdeanexpensify lemme know if you need me to apply the translations for you |
joekaufmanexpensify
previously approved these changes
Dec 2, 2025
joekaufmanexpensify
left a comment
joekaufmanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Good from a product perspective 👍
Contributor
Author
|
Yes please @NikkiWines ! |
Contributor
|
@carlosmiceli all you! |
Contributor
|
@carlosmiceli frinedly bump here - should be quick 🙇 |
carlosmiceli
previously approved these changes
Dec 11, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 04b4e0ea..d9bac7f3 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1567,7 +1567,7 @@ const translations: TranslationDeepObject<typeof en> = {
},
addApprover: {
subtitle: 'Wählen Sie eine zusätzliche genehmigende Person für diesen Bericht aus, bevor wir ihn durch den restlichen Genehmigungs-Workflow weiterleiten.',
- bulkSubtitle: 'Wähle eine zusätzliche genehmigende Person für diese Berichte aus, bevor wir sie durch den restlichen Genehmigungs-Workflow leiten.',
+ bulkSubtitle: 'Wähle eine zusätzliche Genehmigungsperson für diese Berichte, bevor wir sie durch den restlichen Genehmigungs-Workflow weiterleiten.',
},
bulkSubtitle: 'Wählen Sie eine Option, um den Genehmiger für diese Berichte zu ändern.',
},
@@ -2338,7 +2338,7 @@ ${amount} für ${merchant} – ${date}`,
title: 'Keine Mitglieder zum Anzeigen',
expensesFromSubtitle: 'Alle Arbeitsbereichsmitglieder gehören bereits zu einem bestehenden Genehmigungsworkflow.',
approverSubtitle: 'Alle Genehmigenden gehören zu einem bestehenden Workflow.',
- bulkApproverSubtitle: 'Keine Genehmigenden entsprechen den Kriterien für die ausgewählten Berichte.',
+ bulkApproverSubtitle: 'Für die ausgewählten Berichte entsprechen keine Genehmiger den Kriterien.',
},
},
workflowsDelayedSubmissionPage: {
@@ -5092,15 +5092,15 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
},
companyCards: {
title: 'Firmenkarten',
- subtitle: 'Ausgaben von vorhandenen Firmenkarten importieren.',
+ subtitle: 'Verbinde die Karten, die du bereits hast.',
feed: {
- title: 'Firmenkarten importieren',
+ title: 'Eigene Karten mitbringen (BYOC)',
features: {
- support: 'Verbinde Karten von über 10.000 Banken',
- assignCards: 'Verknüpfe die vorhandenen Karten deines Teams',
- automaticImport: 'Wir importieren Transaktionen automatisch.',
+ support: 'Karten von über 10.000 Banken verbinden',
+ assignCards: 'Verknüpfen Sie die vorhandenen Karten Ihres Teams',
+ automaticImport: 'Wir werden Transaktionen automatisch abrufen',
},
- subtitle: 'Verknüpfe die Karten, die du bereits hast, für den automatischen Transaktionsimport, Belegabgleich und Abstimmung.',
+ subtitle: 'Verknüpfe die Karten, die du bereits hast, um Transaktionen automatisch zu importieren, Belege abzugleichen und Abstimmungen durchzuführen.',
},
bankConnectionError: 'Problem mit Bankverbindung',
connectWithPlaid: 'Über Plaid verbinden',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e5a124e3..74c9c178 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1568,9 +1568,9 @@ const translations: TranslationDeepObject<typeof en> = {
},
addApprover: {
subtitle: 'Choisissez un approbateur supplémentaire pour ce rapport avant que nous ne le transmettions au reste du processus de validation.',
- bulkSubtitle: 'Choisissez un approbateur supplémentaire pour ces rapports avant que nous ne les transmettions pour le reste du flux de validation.',
+ bulkSubtitle: 'Choisissez un approbateur supplémentaire pour ces rapports avant que nous ne les envoyions à travers le reste du processus de validation.',
},
- bulkSubtitle: 'Choisissez une option pour changer l’approbateur de ces rapports.',
+ bulkSubtitle: 'Choisissez une option pour modifier l’approbateur de ces rapports.',
},
chooseWorkspace: 'Choisir un espace de travail',
},
@@ -5097,15 +5097,15 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
},
companyCards: {
title: 'Cartes d’entreprise',
- subtitle: 'Importer les dépenses depuis les cartes d’entreprise existantes.',
+ subtitle: 'Connectez les cartes que vous avez déjà.',
feed: {
- title: 'Importer les cartes d’entreprise',
+ title: 'Apportez vos propres cartes (BYOC)',
features: {
- support: 'Prise en charge de tous les principaux émetteurs de cartes',
- assignCards: 'Attribuer des cartes à toute l’équipe',
- automaticImport: 'Importation automatique des transactions',
+ support: 'Connectez des cartes depuis plus de 10 000 banques',
+ assignCards: 'Liez les cartes existantes de votre équipe',
+ automaticImport: 'Nous importerons automatiquement les transactions',
},
- subtitle: 'Liez les cartes que vous avez déjà pour l’importation automatique des transactions, la correspondance des reçus et le rapprochement.',
+ subtitle: 'Liez les cartes que vous avez déjà pour l’importation automatique des transactions, la correspondance des reçus et la réconciliation.',
},
bankConnectionError: 'Problème de connexion bancaire',
connectWithPlaid: 'se connecter via Plaid',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 99633226..5761f18c 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1565,7 +1565,7 @@ const translations: TranslationDeepObject<typeof en> = {
subtitle: 'Scegli un approvatore aggiuntivo per questo resoconto prima che lo instradiamo attraverso il resto del flusso di approvazione.',
bulkSubtitle: 'Scegli un approvatore aggiuntivo per questi report prima che li instradiamo attraverso il resto del flusso di approvazione.',
},
- bulkSubtitle: "Scegli un'opzione per cambiare l'approvatore di questi report.",
+ bulkSubtitle: 'Scegli un’opzione per cambiare l’approvatore per questi report.',
},
chooseWorkspace: 'Scegli uno spazio di lavoro',
},
@@ -5078,11 +5078,11 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
feed: {
title: 'Porta le tue carte (BYOC)',
features: {
- support: 'Supporto per tutti i principali fornitori di carte',
- assignCards: 'Assegna carte a tutto il team',
- automaticImport: 'Importazione automatica delle transazioni',
+ support: 'Collega carte da oltre 10.000 banche',
+ assignCards: 'Collega le carte esistenti del tuo team',
+ automaticImport: 'Importeremo automaticamente le transazioni',
},
- subtitle: "Collega le carte che hai già per l'importazione automatica delle transazioni, l'abbinamento delle ricevute e la riconciliazione.",
+ subtitle: 'Collega le carte che hai già per l’importazione automatica delle transazioni, l’abbinamento delle ricevute e la riconciliazione.',
},
bankConnectionError: 'Problema di connessione bancaria',
connectWithPlaid: 'connetti tramite Plaid',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 0cacdcc6..6f973d94 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1564,7 +1564,7 @@ const translations: TranslationDeepObject<typeof en> = {
},
addApprover: {
subtitle: 'このレポートを残りの承認ワークフローに回付する前に、追加の承認者を選択してください。',
- bulkSubtitle: '残りの承認ワークフローに回す前に、これらのレポートの追加承認者を選択してください。',
+ bulkSubtitle: '残りの承認ワークフローに回付する前に、これらのレポートに対する追加の承認者を選択してください。',
},
bulkSubtitle: 'これらのレポートの承認者を変更する方法を選択してください。',
},
@@ -2323,7 +2323,7 @@ ${merchant} への ${amount}（${date}）`,
title: '表示するメンバーがいません',
expensesFromSubtitle: 'すべてのワークスペースメンバーは、すでに既存の承認ワークフローに属しています。',
approverSubtitle: 'すべての承認者は既存のワークフローに属しています。',
- bulkApproverSubtitle: '選択されたレポートの条件に一致する承認者がいません。',
+ bulkApproverSubtitle: '選択したレポートの条件に一致する承認者がいません。',
},
},
workflowsDelayedSubmissionPage: {
@@ -5046,14 +5046,11 @@ _より詳しい手順については、[ヘルプサイトをご覧ください
},
companyCards: {
title: '会社カード',
- subtitle: '既存の会社カードから支出をインポートする',
+ subtitle: '既にお持ちのカードを連携します。',
feed: {
- title: '会社カードをインポート',
- features: {
- support: '主要なすべてのカードプロバイダーに対応',
- assignCards: 'チーム全員にカードを割り当てる',
- automaticImport: '自動取引インポート',
- },
+ title: '自分のカードを持ち込む（BYOC）',
+ features: {support: '10,000以上の銀行のカードを連携', assignCards: 'チームの既存のカードをリンクする', automaticImport: '取引を自動的に取り込みます'},
+ subtitle: 'すでにお持ちのカードをリンクして、自動取引の取り込み、レシート照合、および消込を行いましょう。',
},
bankConnectionError: '銀行接続の問題',
connectWithPlaid: 'Plaid で接続',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 9ecec1e2..5443a832 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1563,7 +1563,7 @@ const translations: TranslationDeepObject<typeof en> = {
subtitle: 'Kies een extra fiatteur voor dit rapport voordat we het door de rest van de goedkeuringsworkflow sturen.',
bulkSubtitle: 'Kies een extra fiatteur voor deze rapporten voordat we ze door de rest van de goedkeuringsworkflow sturen.',
},
- bulkSubtitle: 'Kies een optie om de fiatteur voor deze rapporten te wijzigen.',
+ bulkSubtitle: 'Kies een optie om de goedkeurder voor deze rapporten te wijzigen.',
},
chooseWorkspace: 'Kies een workspace',
},
@@ -2327,7 +2327,7 @@ ${amount} voor ${merchant} - ${date}`,
title: 'Geen leden om weer te geven',
expensesFromSubtitle: 'Alle werkruimteleden behoren al tot een bestaande goedkeuringsworkflow.',
approverSubtitle: 'Alle fiatteurs behoren tot een bestaande workflow.',
- bulkApproverSubtitle: 'Geen goedkeurders komen overeen met de criteria voor de geselecteerde rapporten.',
+ bulkApproverSubtitle: 'Geen fiatteurs komen overeen met de criteria voor de geselecteerde rapporten.',
},
},
workflowsDelayedSubmissionPage: {
@@ -5067,15 +5067,15 @@ _Voor gedetailleerdere instructies, [bezoek onze helpsite](${CONST.NETSUITE_IMPO
},
companyCards: {
title: 'Bedrijfskaarten',
- subtitle: 'Uitgaven importeren van bestaande zakelijke kaarten.',
+ subtitle: 'Koppel de kaarten die je al hebt.',
feed: {
- title: 'Bedrijfskaarten importeren',
+ title: 'Gebruik je eigen kaarten (BYOC)',
features: {
- support: 'Ondersteuning voor alle grote kaartaanbieders',
- assignCards: 'Kaarten toewijzen aan het hele team',
- automaticImport: 'Automatische transactie-import',
+ support: 'Koppel kaarten van meer dan 10.000 banken',
+ assignCards: 'Koppel de bestaande kaarten van je team',
+ automaticImport: 'We halen transacties automatisch op',
},
- subtitle: 'Koppel de kaarten die je al hebt voor het automatisch importeren van transacties, het matchen van bonnen en het afstemmen.',
+ subtitle: 'Koppel de kaarten die je al hebt voor automatische transactie-import, bonkoppeling en reconciliatie.',
},
bankConnectionError: 'Probleem met bankverbinding',
connectWithPlaid: 'verbinden via Plaid',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index f5d77157..3866a07c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1560,9 +1560,9 @@ const translations: TranslationDeepObject<typeof en> = {
},
addApprover: {
subtitle: 'Wybierz dodatkową osobę zatwierdzającą ten raport, zanim uruchomimy dalszą część procesu akceptacji.',
- bulkSubtitle: 'Wybierz dodatkowego akceptującego dla tych raportów, zanim przekażemy je dalej w pozostałej części procesu zatwierdzania.',
+ bulkSubtitle: 'Wybierz dodatkowego akceptującego dla tych raportów, zanim przekażemy je dalej w pozostałej części procesu akceptacji.',
},
- bulkSubtitle: 'Wybierz opcję, aby zmienić akceptującego dla tych raportów.',
+ bulkSubtitle: 'Wybierz opcję, aby zmienić osobę zatwierdzającą dla tych raportów.',
},
chooseWorkspace: 'Wybierz przestrzeń roboczą',
},
@@ -2325,7 +2325,7 @@ ${amount} dla ${merchant} - ${date}`,
title: 'Brak członków do wyświetlenia',
expensesFromSubtitle: 'Wszyscy członkowie przestrzeni roboczej należą już do istniejącego obiegu zatwierdzania.',
approverSubtitle: 'Wszyscy zatwierdzający należą do istniejącego przepływu pracy.',
- bulkApproverSubtitle: 'Żaden akceptujący nie spełnia kryteriów dla wybranych raportów.',
+ bulkApproverSubtitle: 'Żaden zatwierdzający nie spełnia kryteriów dla wybranych raportów.',
},
},
workflowsDelayedSubmissionPage: {
@@ -5059,15 +5059,15 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
},
companyCards: {
title: 'Firmowe karty',
- subtitle: 'Importuj wydatki z istniejących kart firmowych.',
+ subtitle: 'Połącz karty, które już masz.',
feed: {
- title: 'Zaimportuj karty firmowe',
+ title: 'Użyj własnych kart (BYOC)',
features: {
- support: 'Obsługa wszystkich głównych dostawców kart',
- assignCards: 'Przypisz karty całemu zespołowi',
- automaticImport: 'Automatyczny import transakcji',
+ support: 'Podłącz karty z ponad 10 000 banków',
+ assignCards: 'Połącz istniejące karty Twojego zespołu',
+ automaticImport: 'Automatycznie pobierzemy transakcje',
},
- subtitle: 'Połącz posiadane karty w celu automatycznego importu transakcji, dopasowywania paragonów i uzgadniania.',
+ subtitle: 'Połącz karty, które już masz, aby automatycznie importować transakcje, dopasowywać paragony i przeprowadzać uzgodnienia.',
},
bankConnectionError: 'Problem z połączeniem bankowym',
connectWithPlaid: 'połącz przez Plaid',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index b42fec0d..111fb21c 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1559,7 +1559,7 @@ const translations: TranslationDeepObject<typeof en> = {
},
addApprover: {
subtitle: 'Escolha um aprovador adicional para este relatório antes de o encaminharmos pelo restante do fluxo de aprovação.',
- bulkSubtitle: 'Escolha um aprovador adicional para estes relatórios antes de seguirmos pelo restante do fluxo de aprovação.',
+ bulkSubtitle: 'Escolha um aprovador adicional para estes relatórios antes de seguirmos com o restante do fluxo de aprovação.',
},
bulkSubtitle: 'Escolha uma opção para alterar o aprovador destes relatórios.',
},
@@ -5058,15 +5058,15 @@ _Para instruções mais detalhadas, [visite nosso site de ajuda](${CONST.NETSUIT
},
companyCards: {
title: 'Cartões corporativos',
- subtitle: 'Importar gastos de cartões corporativos existentes.',
+ subtitle: 'Conecte os cartões que você já tem.',
feed: {
title: 'Traga seus próprios cartões (BYOC)',
features: {
support: 'Conecte cartões de mais de 10.000 bancos',
assignCards: 'Vincule os cartões existentes da sua equipe',
- automaticImport: 'Importaremos as transações automaticamente',
+ automaticImport: 'Vamos importar as transações automaticamente',
},
- subtitle: 'Conecte os cartões que você já tem para importação automática de transações, associação de recibos e conciliação.',
+ subtitle: 'Vincule os cartões que você já possui para importação automática de transações, correspondência de recibos e reconciliação.',
},
bankConnectionError: 'Problema de conexão bancária',
connectWithPlaid: 'conectar via Plaid',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index fe0ccd37..30260436 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1536,7 +1536,7 @@ const translations: TranslationDeepObject<typeof en> = {
bypassApprovers: '绕过审批人',
bypassApproversSubtitle: '将自己指定为最终审批人，并跳过所有剩余审批人。',
},
- addApprover: {subtitle: '在我们将此报销单送交其余审批流程之前，请为其选择一位额外的审批人。', bulkSubtitle: '在我们将这些报表提交给其余审批流程之前，请为其选择一位额外审批人。'},
+ addApprover: {subtitle: '在我们将此报销单送交其余审批流程之前，请为其选择一位额外的审批人。', bulkSubtitle: '在我们将这些报告提交到其余审批流程之前，请选择一名额外的审批人。'},
bulkSubtitle: '选择一个选项来更改这些报表的审批人。',
},
chooseWorkspace: '选择一个工作区',
@@ -2292,7 +2292,7 @@ ${amount}，商户：${merchant} - ${date}`,
title: '没有可显示的成员',
expensesFromSubtitle: '所有工作区成员已属于现有的审批流程。',
approverSubtitle: '所有审批人都属于一个现有的工作流程。',
- bulkApproverSubtitle: '所选报表中没有符合条件的审批人。',
+ bulkApproverSubtitle: '没有审批人符合所选报表的条件。',
},
},
workflowsDelayedSubmissionPage: {
@@ -4971,14 +4971,11 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
},
companyCards: {
title: '公司信用卡',
- subtitle: '从现有公司卡导入支出。',
+ subtitle: '连接你已有的卡片。',
feed: {
- title: '导入公司卡片',
- features: {
- support: '支持所有主要的卡片提供商',
- assignCards: '将卡片分配给整个团队',
- automaticImport: '自动导入交易',
- },
+ title: '自带卡片（BYOC）',
+ features: {support: '连接来自 10,000 多家银行的卡片', assignCards: '关联你团队的现有卡片', automaticImport: '我们会自动导入交易记录'},
+ subtitle: '关联你已有的卡片，以自动导入交易、匹配收据并进行对账。',
},
bankConnectionError: '银行连接问题',
connectWithPlaid: '通过 Plaid 连接',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
NikkiWines
reviewed
Dec 12, 2025
| @@ -4606,6 +4606,7 @@ ${amount} para ${merchant} - ${date}`, | |||
| subtitle: 'Importar gastos de las tarjetas de empresa existentes.', | |||
Contributor
There was a problem hiding this comment.
These don't seem to have been update for some reason :fry:
carlosmiceli
previously approved these changes
Dec 12, 2025
Contributor
|
@carlosmiceli once more please 🙇 updated the spanish translations |
carlosmiceli
approved these changes
Dec 16, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.79-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.81-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
https://expensify.slack.com/archives/C03SSAQG5/p1764014587436879?thread_ts=1763431093.297579&cid=C03SSAQG5
$
PROPOSAL:
Tests
Offline tests
QA Steps
More featuressection of a workspaceCompany cardssection is updatedPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari