Fix: While scan is in progress, more menu displays submit option#76610
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
JmillsExpensify and
QichenZhu
and removed request for
a team
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return false; | ||
| } | ||
|
|
||
| const isAnyReceiptBeingScanned = reportTransactions?.some((transaction) => isReceiptBeingScanned(transaction)); |
Contributor
There was a problem hiding this comment.
❌ PERF-2 (docs)
The .some() call with isReceiptBeingScanned(transaction) is an expensive operation (function call) that should be performed AFTER the simple property checks. The transactionAreComplete check on line 150 uses primitive comparisons (transaction.amount !== 0 || transaction.modifiedAmount !== 0) which are much simpler and should execute first to eliminate items early.
Suggested fix: Move the receipt scanning check after the transactionAreComplete check:
const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || transaction.modifiedAmount !== 0);
if (!transactionAreComplete) {
return false;
}
const isAnyReceiptBeingScanned = reportTransactions?.some((transaction) => isReceiptBeingScanned(transaction));
if (isAnyReceiptBeingScanned) {
return false;
}
Contributor
Author
|
For the scan fails issue, we hide the submit button when transactions have |
JmillsExpensify
left a comment
JmillsExpensify
left a comment
Contributor
There was a problem hiding this comment.
Yeah, you shouldn't be able to submit a scanning expense. Product approved.
QichenZhu
reviewed
Dec 8, 2025
Comment on lines
+50
to
+53
| const hasSmartScanFailedViolation = transactions?.some((transaction) => { | ||
| const transactionViolations = getTransactionViolations(transaction, violations, currentUserEmail, currentUserAccountID, report, policy); | ||
| return transactionViolations?.some((violation) => violation.name === CONST.VIOLATIONS.SMARTSCAN_FAILED); | ||
| }); |
Contributor
There was a problem hiding this comment.
Is this approach better than checking transaction?.receipt?.state === CONST.IOU.RECEIPT_STATE.SCAN_FAILED?
Also, please extract it into a util since this logic is duplicated in three places.
Contributor
Author
There was a problem hiding this comment.
I tested both approaches and found that transaction?.receipt?.state remains SCANFAILED even after the user manually enters the missing fields (amount, merchant, etc.). This means if we check the receipt state directly, the submit button would stay hidden once a scan fails, even after the user fixes everything:
MacOS-Chrome.mp4
Meanwhile the violation approach allows submit action once the user has addressed the failed scan violation. In this case, entering either amount and merchant field should be enough, as the backend accept this condition as well
MacOS-Chrome.mp4
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-native.webmAndroid: mWeb Chromeandroid-web.webmiOS: HybridAppios-native.moviOS: mWeb Safariios-web.movMacOS: Chrome / SafariScreen.Recording.2025-12-12.at.12.19.47.AM.mov |
Contributor
|
NAB: We are adding optional arguments to isSubmitAction(), but I can't test whether we need to update its usage in useTools() which is not used in our app yet. cc @carlosmiceli |
QichenZhu
approved these changes
Dec 11, 2025
madmax330
approved these changes
Dec 15, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.79-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.81-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR prevents the submit option from being shown in report secondary actions when any receipt is being scanned
Fixed Issues
$ #75840
PROPOSAL: #75840 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4