Skip to content

Revert "Revert "[CP Staging] Revert "Update approval mode in upgrade"""#76725

Merged
cristipaval merged 1 commit into
mainfrom
revert-76420-revert-76182-revert-72550-revert-70362-fix/69362
Dec 4, 2025
Merged

Revert "Revert "[CP Staging] Revert "Update approval mode in upgrade"""#76725
cristipaval merged 1 commit into
mainfrom
revert-76420-revert-76182-revert-72550-revert-70362-fix/69362

Conversation

@cristipaval

Copy link
Copy Markdown
Contributor

Straight revert

It reverts #76420 because it introduced an ESLint warning in main, and the issue that it fixes is not critical.

@cristipaval cristipaval self-assigned this Dec 4, 2025
@cristipaval cristipaval requested review from a team as code owners December 4, 2025 15:31
@melvin-bot melvin-bot Bot requested review from heyjennahay and lakchote and removed request for a team December 4, 2025 15:32
@melvin-bot

melvin-bot Bot commented Dec 4, 2025

Copy link
Copy Markdown

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cristipaval cristipaval merged commit 75a6a1f into main Dec 4, 2025
31 of 34 checks passed
@cristipaval cristipaval deleted the revert-76420-revert-76182-revert-72550-revert-70362-fix/69362 branch December 4, 2025 15:33
@melvin-bot melvin-bot Bot added the Emergency label Dec 4, 2025
@melvin-bot

melvin-bot Bot commented Dec 4, 2025

Copy link
Copy Markdown

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@cristipaval

Copy link
Copy Markdown
Contributor Author

Straight revert

@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...c/pages/workspace/upgrade/WorkspaceUpgradePage.tsx 38.65% <ø> (+0.44%) ⬆️
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx 0.00% <0.00%> (ø)
...rc/pages/workspace/members/ImportedMembersPage.tsx 0.00% <0.00%> (ø)
... and 6 files with indirect coverage changes

@OSBotify

OSBotify commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.73-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.73-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants