-
Notifications
You must be signed in to change notification settings - Fork 3.9k
use PopoverMenu #7677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Julesssss
merged 6 commits into
Expensify:main
from
thesahindia:thesahindia/ui/fix-payment-methods-container
Mar 2, 2022
Merged
use PopoverMenu #7677
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
328c12f
use PopoverMenu
thesahindia 245cb51
add PopoverMenu to stories
thesahindia 346001c
Merge branch 'main' of github.com:thesahindia/App into thesahindia/ui…
thesahindia 2f6c1b4
fix lint errors
thesahindia 78eabbc
remove extra line
thesahindia 5dab0ff
pass required props
thesahindia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import React from 'react'; | ||
| import {SafeAreaProvider} from 'react-native-safe-area-context'; | ||
| import PopoverMenu from '../components/PopoverMenu'; | ||
| import * as Expensicons from '../components/Icon/Expensicons'; | ||
| import MenuItem from '../components/MenuItem'; | ||
| import colors from '../styles/colors'; | ||
|
|
||
| /** | ||
| * We use the Component Story Format for writing stories. Follow the docs here: | ||
| * | ||
| * https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format | ||
| */ | ||
| const story = { | ||
| title: 'Components/PopoverMenu', | ||
| component: PopoverMenu, | ||
| }; | ||
|
|
||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| const Template = (args) => { | ||
| const [isVisible, setIsVisible] = React.useState(false); | ||
| const toggleVisibility = () => setIsVisible(!isVisible); | ||
| return ( | ||
| <> | ||
| <MenuItem | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...args.menuItem} | ||
| onPress={toggleVisibility} | ||
| wrapperStyle={isVisible ? [{backgroundColor: colors.gray2}] : []} | ||
| /> | ||
| <SafeAreaProvider> | ||
|
thesahindia marked this conversation as resolved.
|
||
| <PopoverMenu | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...args.popoverMenu} | ||
| isVisible={isVisible} | ||
| onClose={toggleVisibility} | ||
|
thesahindia marked this conversation as resolved.
|
||
| onItemSelected={toggleVisibility} | ||
| menuItems={[ | ||
| { | ||
| text: 'Bank account', | ||
| icon: Expensicons.Bank, | ||
| onSelected: toggleVisibility, | ||
| }, | ||
| { | ||
| text: 'Debit card', | ||
| icon: Expensicons.CreditCard, | ||
| onSelected: toggleVisibility, | ||
| }, | ||
| { | ||
| text: 'PayPal.me', | ||
| icon: Expensicons.PayPal, | ||
| onSelected: toggleVisibility, | ||
| }, | ||
| ]} | ||
| /> | ||
| </SafeAreaProvider> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| // Arguments can be passed to the component by binding | ||
| // See: https://storybook.js.org/docs/react/writing-stories/introduction#using-args | ||
| const Default = Template.bind({}); | ||
| Default.args = { | ||
| popoverMenu: { | ||
| anchorPosition: { | ||
| top: 80, | ||
| left: 20, | ||
| }, | ||
| }, | ||
| menuItem: { | ||
| title: 'Add payment Methods', | ||
| icon: Expensicons.Plus, | ||
| }, | ||
| }; | ||
|
|
||
| export default story; | ||
| export { | ||
| Default, | ||
| }; | ||
|
thesahindia marked this conversation as resolved.
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.