fix: Distance rate changes are not translated in non-English in admin room#76888
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
This result looks good to me.
Verify that the Distance rate actions is translated in the thread and thread header
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-11.at.2.56.35.PM.movAndroid: mWeb ChromeScreen.Recording.2025-12-11.at.3.03.33.PM.moviOS: HybridAppScreen.Recording.2025-12-11.at.2.20.36.PM.moviOS: mWeb SafariScreen.Recording.2025-12-11.at.2.25.54.PM.movMacOS: Chrome / SafariScreen.Recording.2025-12-11.at.2.14.51.PM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @grgia
🎀 👀 🎀
C+ Reviewed
|
@grgia We're good to merge now. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.79-0 🚀
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
Explanation of Change
Fixed Issues
$ #75842
PROPOSAL: #75842 (comment)
Tests
Offline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-06.at.22.48.32.mov
Android: mWeb Chrome
Screen.Recording.2025-12-06.at.22.49.02.mov
iOS: Native
Screen.Recording.2025-12-06.at.22.49.20.mov
iOS: mWeb Safari
Screen.Recording.2025-12-06.at.22.49.41.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-06.at.22.46.18.mov