Skip to content

[DRAFT] Tooltip Draft PR#769

Closed
roryabraham wants to merge 4 commits into
masterfrom
Rory-secondDraftTooltip
Closed

[DRAFT] Tooltip Draft PR#769
roryabraham wants to merge 4 commits into
masterfrom
Rory-secondDraftTooltip

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

cc @Luke9389

Fixed Issues

Fixes GH_LINK

Tests

Screenshots

@roryabraham roryabraham requested a review from a team as a code owner November 6, 2020 01:51
@botify botify requested review from joelbettner and removed request for a team November 6, 2020 01:52
@roryabraham roryabraham removed the request for review from joelbettner November 6, 2020 01:52
@roryabraham roryabraham assigned roryabraham and unassigned Luke9389 Nov 6, 2020
@shawnborton

Copy link
Copy Markdown
Contributor

Heyo - just curious if there are designs you are working off of, or rather, what is the linked GH for the issue this addresses?

@roryabraham

roryabraham commented Nov 7, 2020

Copy link
Copy Markdown
Contributor Author

Hey Shawn. We're working on tooltips because they're included in the CommentActions doc (there are a few design mockups including tooltips in there). Turns out that tooltips are a pretty foreign concept in RN, so this is really just a POC so we can describe a tooltip solution in the doc. But since there was no out-of-the-box solution, I had to make sure that what I had in mind would actually work, so here we are. 😄

I brought Luke in and he's been helping me build a positioning engine that we're pretty sure will cover most use cases for tooltips, and which will be covered in detail in the design doc. Happy to work on polishing the appearance of tooltips when we're no longer in the POC phase, during the actual implementation of this feature.

@roryabraham roryabraham closed this Feb 9, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 9, 2021
@roryabraham roryabraham deleted the Rory-secondDraftTooltip branch July 6, 2022 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants