Skip to content

remove notification Subheader#7692

Merged
Julesssss merged 2 commits into
Expensify:mainfrom
mateusbra:remove-notificationSubHeader
Feb 11, 2022
Merged

remove notification Subheader#7692
Julesssss merged 2 commits into
Expensify:mainfrom
mateusbra:remove-notificationSubHeader

Conversation

@mateusbra

@mateusbra mateusbra commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

Details

Remove notification Subheader

Fixed Issues

$ #7670

Tests | QA Steps

  1. Click "+"
  2. Click "New room"
  3. Add any room name, choose any workspace, choose any visibility setting - Click "Create room"
  4. Click the room header in the main chat pane to be taken to the room "Setting" pane
  5. Verify notification Subheader was removed.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

Captura de Tela 2022-02-10 às 21 33 57

iOS

Captura de Tela 2022-02-10 às 14 14 40

Android

image

@mateusbra mateusbra requested a review from a team as a code owner February 10, 2022 23:04
@Julesssss Julesssss requested review from roryabraham and removed request for a team February 11, 2022 10:35
@Julesssss Julesssss requested review from a team and removed request for roryabraham February 11, 2022 10:36
@MelvinBot MelvinBot requested review from Julesssss and parasharrajat and removed request for a team February 11, 2022 10:36
@Julesssss

Copy link
Copy Markdown
Contributor

Ignore that @roryabraham, I missclicked.

@Julesssss

Copy link
Copy Markdown
Contributor

Actually, I'm holding my review for now, as I'm unable to open the settings menu. I tried updating all repos with no luck 😕

Screenshot 2022-02-11 at 11 57 27

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @Julesssss.

🎀 👀 🎀 C+ reviewed

@mateusbra

Copy link
Copy Markdown
Contributor Author

@Julesssss I had this issue a few times on IOS. I tryed to reload the app and it worked for me.

@Julesssss Julesssss merged commit 1e70a89 into Expensify:main Feb 11, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Julesssss

Copy link
Copy Markdown
Contributor

God knows what the issue was, but I was finally able to verify!

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.39-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @timszot in version: 1.1.39-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants