Skip to content

Add isFromCreditCardImport to check the transaction from import card #77243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madmax330 merged 7 commits into from
Dec 26, 2025
+29 −1
Merged

Add isFromCreditCardImport to check the transaction from import card #77243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4dbd926
add isFromCreditCardImport to check the transaction from import card
mollfpr Dec 10, 2025
f26a6d2
Merge branch 'main' of github.com:Expensify/App into mollfpr-show-car…
mollfpr Dec 15, 2025
6c9fbcf
Merge branch 'main' of github.com:Expensify/App into mollfpr-show-car…
mollfpr Dec 18, 2025
e7bc85c
move upload to new constant
mollfpr Dec 18, 2025
035ea55
Merge branch 'main' of github.com:Expensify/App into mollfpr-show-car…
mollfpr Dec 18, 2025
2e006ac
Merge branch 'main' of github.com:Expensify/App into mollfpr-show-car…
mollfpr Dec 19, 2025
a1a5bd9
Merge branch 'main' of github.com:Expensify/App into mollfpr-show-car…
mollfpr Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3576,6 +3576,9 @@ const CONST = {
CARD_NAME: {
CASH: '__CASH__',
},
BANK_NAME: {
UPLOAD: 'upload',
},
CARD_LIST_THRESHOLD: 8,
DEFAULT_EXPORT_TYPE: 'default',
EXPORT_CARD_TYPES: {
Expand Down
2 changes: 1 addition & 1 deletion src/components/ReportActionItem/MoneyRequestView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ import {
hasMissingSmartscanFields,
hasReservationList,
hasRoute as hasRouteTransactionUtils,
isManagedCardTransaction as isCardTransactionTransactionUtils,
isFromCreditCardImport as isCardTransactionTransactionUtils,

@madmax330 madmax330 Dec 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this unused? If it's used shouldn't we update it somewhere in this file?

@mollfpr mollfpr Dec 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to change isManagedCardTransaction to isFromCreditCardImport, because in the file we use isCardTransactionTransactionUtils. Both functions have the same params and the same purpose, but isFromCreditCardImport enhances to check imported transaction from personal card.

@abzokhattab abzokhattab Apr 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change caused #81997. Replacing isManagedCardTransaction with isFromCreditCardImport (while keeping the alias isCardTransactionTransactionUtils) made the shouldShowReimbursable condition use a broader check that returns true for all card imports — including personal cards. This incorrectly hid the Reimbursable toggle for personal card transactions. The fix in #84596 uses the real isManagedCardTransaction specifically for shouldShowReimbursable, which only targets centrally managed cards.

isCategoryBeingAnalyzed,
isDistanceRequest as isDistanceRequestTransactionUtils,
isExpenseUnreported as isExpenseUnreportedTransactionUtils,
Expand Down
25 changes: 25 additions & 0 deletions src/libs/TransactionUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
};

let deprecatedAllReports: OnyxCollection<Report> = {};
Onyx.connect({

Check warning on line 129 in src/libs/TransactionUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT,
waitForCollectionCallback: true,
callback: (value) => {
Expand All @@ -135,7 +135,7 @@
});

let deprecatedAllTransactionViolations: OnyxCollection<TransactionViolations> = {};
Onyx.connect({

Check warning on line 138 in src/libs/TransactionUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
waitForCollectionCallback: true,
callback: (value) => (deprecatedAllTransactionViolations = value),
Expand Down Expand Up @@ -1134,6 +1134,30 @@
return !!transaction?.managedCard;
}

/**
* Determine whether a transaction is imported from a credit card.
* This includes managed cards (Expensify/Company cards) and personal cards imported via bank connection.
*/
function isFromCreditCardImport(transaction: OnyxEntry<Transaction>): boolean {
if (transaction?.bank === CONST.COMPANY_CARDS.BANK_NAME.UPLOAD) {
return false;
}

if (isManagedCardTransaction(transaction)) {
return true;
}

if (transaction?.cardNumber) {
return true;
}

if (transaction?.bank) {
return true;
}

return false;
}

function getCardName(transaction: OnyxEntry<Transaction>): string {
return transaction?.cardName ?? '';
}
Expand Down Expand Up @@ -2515,6 +2539,7 @@
mergeProhibitedViolations,
getOriginalAttendees,
getReportOwnerAsAttendee,
isFromCreditCardImport,
getExchangeRate,
shouldReuseInitialTransaction,
getOriginalAmountForDisplay,
Expand Down
Loading