Skip to content

fix menu scroll issue #77444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuckdries merged 2 commits into from
Dec 12, 2025
Merged

fix menu scroll issue #77444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd336d
fix menu scroll issue
Nodebrute Dec 11, 2025
6fd6781
standarize dropdown threshold
Nodebrute Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ const CONST = {
POPOVER_DATE_MAX_HEIGHT: 366,
POPOVER_DATE_MIN_HEIGHT: 322,
TOOLTIP_ANIMATION_DURATION: 500,
DROPDOWN_SCROLL_THRESHOLD: 5,
// Multiplier for gyroscope animation in order to make it a bit more subtle
ANIMATION_GYROSCOPE_VALUE: 0.4,
ANIMATION_PAID_DURATION: 200,
Expand Down
2 changes: 1 addition & 1 deletion src/components/MoneyReportHeaderKYCDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function MoneyReportHeaderKYCDropdown({
}}
buttonRef={buttonRef}
shouldAlwaysShowDropdownMenu
shouldPopoverUseScrollView={applicableSecondaryActions.length >= 5}
shouldPopoverUseScrollView={applicableSecondaryActions.length >= CONST.DROPDOWN_SCROLL_THRESHOLD}
customText={translate('common.more')}
options={applicableSecondaryActions}
isSplitButton={false}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SettlementButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ function SettlementButton({
}}
style={style}
shouldUseShortForm={shouldUseShortForm}
shouldPopoverUseScrollView={paymentButtonOptions.length > 5}
shouldPopoverUseScrollView={paymentButtonOptions.length >= CONST.DROPDOWN_SCROLL_THRESHOLD}
containerStyles={paymentButtonOptions.length > 5 ? styles.settlementButtonListContainer : {}}
wrapperStyle={[wrapperStyle, shouldLimitWidth ? styles.settlementButtonShortFormWidth : {}]}
disabledStyle={disabledStyle}
Expand Down
1 change: 1 addition & 0 deletions src/pages/Search/SearchSelectedNarrow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ function SearchSelectedNarrow({options, itemsLength, currentSelectedPolicyID, cu
shouldAlwaysShowDropdownMenu
isDisabled={options.length === 0}
onPress={() => null}
shouldPopoverUseScrollView={options.length >= CONST.DROPDOWN_SCROLL_THRESHOLD}
onOptionSelected={(item) => handleOnMenuItemPress(item)}
onSubItemSelected={(subItem) =>
handleBulkPayItemSelected({
Expand Down
Loading