Fix: 'Add bank account' doesn't appear when Account B with no default WS/user currency USD by nyomanjyotisa · Pull Request #77479 · Expensify/App

nyomanjyotisa · 2025-12-12T01:49:54Z

Explanation of Change

Change localCurrencyCode to personalPolicy?.outputCurrency so that the default currency is determined by the user's preferred settings rather than their location. This change will make the "Add bank account" displayed when we select "Pay as business"

Fixed Issues

$ #76596
PROPOSAL: #76596 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition:

The invoice sender's workspace should have the default currency set to USD
Account B has no workspace or no default workspace
Account B has default currency set to USD

Log in with Account A.
Go to Global Create > Create Invoice.
Submit an invoice addressed to Account B.
Log in with Account B.
Open the received invoice.
Tap Pay.
Select Pay as business.
Verify that the "Add bank account" option is displayed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

… WS/user currency USD

codecov · 2025-12-12T01:58:29Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/SettlementButton/index.tsx	`0.35% <0.00%> (-0.01%)`	⬇️
... and 94 files with indirect coverage changes

melvin-bot · 2025-12-12T05:39:45Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-12-12T05:39:50Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

Joe had eyes on the parent issue for this 👍

Krishna2323 · 2025-12-12T19:44:24Z


            const isActivePolicyCurrencySupported = isCurrencySupportedForDirectReimbursement(activePolicy?.outputCurrency ?? '');
-            const isUserCurrencySupported = isCurrencySupportedForDirectReimbursement(localCurrencyCode ?? '');
+            const isUserCurrencySupported = isCurrencySupportedForDirectReimbursement(personalPolicy?.outputCurrency ?? '');


@nyomanjyotisa shouldn't we default to USD when personalPolicy?.outputCurrency is missing?

Oh yeah you're right, I'll change the default to CONST.CURRENCY.USD to keep it consistent with the codebase pattern

Krishna2323 · 2025-12-12T22:01:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

ios_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native_og.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

cristipaval · 2025-12-15T12:19:40Z

@Krishna2323 , did you approve this PR?

Krishna2323

LGTM! 🚀

Krishna2323 · 2025-12-15T16:13:58Z

@cristipaval approved.

OSBotify · 2025-12-15T18:40:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-16T22:48:46Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-12-17T10:13:17Z

@nyomanjyotisa QA team failed this PR with an original issue

1765935498508.Recording__1098.mp4

nyomanjyotisa · 2025-12-17T11:12:11Z

@IuliiaHerets The invoice sender's workspace should also have the default currency set to USD in this case, I believe

We can update the Test Steps section if that is the correct steps

cc @Krishna2323 @cristipaval

IuliiaHerets · 2025-12-17T12:09:06Z

Let us know if we need to recheck the PR

OSBotify · 2025-12-17T12:26:28Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T18:47:57Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:11:21Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Krishna2323 · 2025-12-26T00:40:48Z

@nyomanjyotisa, could you please update the Test Steps section according to this? Thanks!

nyomanjyotisa · 2025-12-26T11:59:27Z

Sure, PR updated!

Fix: 'Add bank account' doesn't appear when Account B with no default…

94c3204

… WS/user currency USD

melvin-bot Bot assigned nyomanjyotisa Dec 12, 2025

lint fix

bb50eab

nyomanjyotisa marked this pull request as ready for review December 12, 2025 05:39

nyomanjyotisa requested review from a team as code owners December 12, 2025 05:39

melvin-bot Bot requested a review from Krishna2323 December 12, 2025 05:39

melvin-bot Bot requested review from a team, cristipaval and trjExpensify and removed request for a team December 12, 2025 05:39

trjExpensify previously approved these changes Dec 12, 2025

View reviewed changes

Krishna2323 reviewed Dec 12, 2025

View reviewed changes

minor fix

91f5077

nyomanjyotisa dismissed trjExpensify’s stale review via 91f5077 December 13, 2025 15:06

Krishna2323 approved these changes Dec 15, 2025

View reviewed changes

cristipaval approved these changes Dec 15, 2025

View reviewed changes

cristipaval merged commit 16c0abf into Expensify:main Dec 15, 2025
33 checks passed

OSBotify mentioned this pull request Dec 16, 2025

Deploy Checklist: New Expensify 2025-12-16 #77818

Closed

melvin-bot Bot mentioned this pull request Dec 18, 2025

[Due for payment 2025-12-25] [$250] Invoices – "Add bank account" doesn't appear when Account B with no default WS/user currency USD #76596

Closed

8 tasks

Conversation

nyomanjyotisa commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Dec 12, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Dec 12, 2025

Uh oh!

melvin-bot Bot commented Dec 12, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Dec 12, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

cristipaval commented Dec 15, 2025

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Dec 15, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 15, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

IuliiaHerets commented Dec 17, 2025

Uh oh!

nyomanjyotisa commented Dec 17, 2025

Uh oh!

IuliiaHerets commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

Krishna2323 commented Dec 26, 2025

Uh oh!

nyomanjyotisa commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nyomanjyotisa commented Dec 12, 2025 •

edited

Loading

codecov Bot commented Dec 12, 2025 •

edited by github-actions Bot

Loading