[No QA] Add eslint rule to limit usage of `SelectionListWithSections` by zfurtak · Pull Request #77737 · Expensify/App

zfurtak · 2025-12-16T08:51:44Z

Explanation of Change

After introducing new SelectionList component designed for usages with 1 section of data, I noticed that people are still using the old one (now called SelectionListWithSections).
In this PR I creating a restricted import for SelectionListWithSections to ensure that people use it only when it's actually needed.

Fixed Issues

$ #77742
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2025-12-16T09:00:29Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/CategoryPicker.tsx	`0.00% <ø> (ø)`
src/components/CurrencySelectionList/index.tsx	`0.00% <ø> (ø)`
src/components/DestinationPicker.tsx	`0.00% <ø> (ø)`
src/components/MoneyRequestConfirmationList.tsx	`58.33% <ø> (ø)`
src/components/Search/SearchAutocompleteList.tsx	`32.44% <ø> (ø)`
...c/components/Search/SearchFiltersChatsSelector.tsx	`0.00% <ø> (ø)`
...nents/Search/SearchFiltersParticipantsSelector.tsx	`0.00% <ø> (ø)`
...omponents/Search/SearchMultipleSelectionPicker.tsx	`0.00% <ø> (ø)`
.../components/Search/SearchSingleSelectionPicker.tsx	`0.00% <ø> (ø)`
src/components/SelectionListWithModal/index.tsx	`88.23% <100.00%> (+0.73%)`	⬆️
... and 24 more
... and 7 files with indirect coverage changes

melvin-bot · 2025-12-16T14:56:07Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-12-16T14:56:45Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-12-17T02:14:04Z

@zfurtak Looks good, do we have the docs on how to use the new pattern?

zfurtak · 2025-12-17T09:02:58Z

I wasn't sure where to add this, wdyt? 🤔

dukenv0307 · 2025-12-17T16:15:40Z

I think we can do it in contributingGuides like https://github.com/Expensify/App/blob/main/contributingGuides/FORMS.md

grgia · 2025-12-18T11:21:59Z

@@ -1,5 +1,6 @@
 import {Str} from 'expensify-common';
 import React, {useCallback, useMemo, useState} from 'react';
+// eslint-disable-next-line no-restricted-imports


are all the disable lines files left to migrate ?

Almost all of them are awaiting the new component for SelectionList with sectioned data

grgia · 2025-12-18T11:24:55Z

    },
+    {
+        name: './SelectionListWithSections',
+        message: 'Use `SelectionList` for flat data. Only use `SelectionListWithSection` when data is actually sectioned.',


is there a more descriptive way to describe sections vs not

I will add more detailed description in docs and put a reference here

zfurtak · 2025-12-18T14:39:51Z

@dukenv0307 I added the doc 👍

grgia

the doc update / eslint comment is great. LGTM

dukenv0307 · 2025-12-19T03:06:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2025-12-19T13:45:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-19T23:59:29Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.85-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-23T00:32:54Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

zfurtak added 3 commits December 16, 2025 08:47

Add restricted import for SelectionListWithSections

95ae4a6

Add missing import

60b7ebd

Add eslint ignore when restricted import should be used

e6496bd

melvin-bot Bot assigned zfurtak Dec 16, 2025

zfurtak added 2 commits December 16, 2025 10:07

Fix lint

ac01522

Fix typo

3fd6c45

blazejkustra approved these changes Dec 16, 2025

View reviewed changes

Comment thread eslint.config.mjs Outdated

Comment thread src/pages/iou/SplitExpensePage.tsx Outdated

Adjust the rule message

9e0a253

grgia requested a review from dukenv0307 December 16, 2025 14:43

zfurtak marked this pull request as ready for review December 16, 2025 14:56

zfurtak requested review from a team as code owners December 16, 2025 14:56

melvin-bot Bot requested review from JmillsExpensify and grgia and removed request for a team December 16, 2025 14:56

melvin-bot Bot requested review from a team and blimpich and removed request for a team December 16, 2025 14:56

melvin-bot Bot removed the request for review from a team December 16, 2025 14:56

grgia removed request for JmillsExpensify and blimpich December 16, 2025 14:57

Merge branch 'main' into @zfurtak/eslint-rule

e646aef

grgia reviewed Dec 18, 2025

View reviewed changes

zfurtak added 3 commits December 18, 2025 14:07

Merge branch 'main' into @zfurtak/eslint-rule

0e73e43

Add docs

bf5197c

Add ignore

0cf1b92

grgia previously approved these changes Dec 18, 2025

View reviewed changes

dukenv0307 approved these changes Dec 19, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia December 19, 2025 03:07

Merge branch 'main' into @zfurtak/eslint-rule

742a4c4

zfurtak dismissed grgia’s stale review via 742a4c4 December 19, 2025 12:19

grgia approved these changes Dec 19, 2025

View reviewed changes

grgia merged commit a304ba6 into Expensify:main Dec 19, 2025
31 checks passed

OSBotify mentioned this pull request Dec 19, 2025

Deploy Checklist: New Expensify 2025-12-19 #78170

Closed

87 tasks

melvin-bot Bot mentioned this pull request Dec 23, 2025

[Due for payment 2025-12-30] [SelectionList] Prevent contributors from using deprecated component #77742

Closed

Conversation

zfurtak commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Dec 16, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Dec 16, 2025

Uh oh!

melvin-bot Bot commented Dec 16, 2025

Uh oh!

dukenv0307 commented Dec 17, 2025

Uh oh!

zfurtak commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Dec 17, 2025

Uh oh!

grgia Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

grgia Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak commented Dec 18, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Dec 19, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zfurtak commented Dec 16, 2025 •

edited

Loading

codecov Bot commented Dec 16, 2025 •

edited by github-actions Bot

Loading

zfurtak commented Dec 17, 2025 •

edited

Loading