[No QA] Create assign-cards#77802
Conversation
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
sakluger
left a comment
There was a problem hiding this comment.
Overall looks great! Once the comments are addressed, I think we can approve merge.
One other thought - should we name the file "assign-and-manage-cards" to match the page title?
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
Co-authored-by: Sasha Kluger <sasha@expensify.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://a0366683.helpdot.pages.dev ⚡️ Updated articles: |
|
@sakluger looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
According to https://stackoverflowteams.com/c/expensify/questions/20516/20517#20517, we do not need to complete the PR checklists for help docs changes. |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.2.85-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀
|
https://github.com/Expensify/Expensify/issues/576486
Explanation of Change
Creating a new page for assigning cards
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari