Skip to content

[CP Staging] Revert "fix: Expense can be categorized via whisper despite "Categories" being disabled."#77908

Merged
inimaga merged 1 commit into
mainfrom
revert-76176-fix_75276
Dec 17, 2025
Merged

[CP Staging] Revert "fix: Expense can be categorized via whisper despite "Categories" being disabled."#77908
inimaga merged 1 commit into
mainfrom
revert-76176-fix_75276

Conversation

@inimaga

@inimaga inimaga commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Reverts #76176

Fixes the deploy blocker: #77838

@inimaga inimaga requested review from a team as code owners December 17, 2025 16:26
@melvin-bot melvin-bot Bot requested review from amyevans and joekaufmanexpensify and removed request for a team December 17, 2025 16:26
@melvin-bot

melvin-bot Bot commented Dec 17, 2025

Copy link
Copy Markdown

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@amyevans

amyevans commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

@inimaga I assume this is to be cherry-picked?

@codecov

codecov Bot commented Dec 17, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/ReportActionsUtils.ts 48.85% <100.00%> (-0.01%) ⬇️
src/pages/home/report/ReportActionsView.tsx 76.92% <100.00%> (-0.20%) ⬇️
... and 14 files with indirect coverage changes

@inimaga

inimaga commented Dec 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@amyevans Yhup, that is correct. Going to merge once the test runs complete and request a CP.

@amyevans amyevans changed the title Revert "fix: Expense can be categorized via whisper despite "Categories" being disabled." [CP Staging] Revert "fix: Expense can be categorized via whisper despite "Categories" being disabled." Dec 17, 2025
@inimaga inimaga merged commit 6f4175a into main Dec 17, 2025
33 of 36 checks passed
@inimaga inimaga deleted the revert-76176-fix_75276 branch December 17, 2025 16:42
@melvin-bot melvin-bot Bot added the Emergency label Dec 17, 2025
@melvin-bot

melvin-bot Bot commented Dec 17, 2025

Copy link
Copy Markdown

@inimaga looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@inimaga inimaga removed the Emergency label Dec 17, 2025
@inimaga

inimaga commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Not an emergency

@OSBotify

OSBotify commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 17, 2025
@inimaga @OSBotify
Merge pull request #77908 from Expensify/revert-76176-fix_75276
5cea09c 
[CP Staging] Revert "fix: Expense can be categorized via whisper despite "Categories" being disabled."

(cherry picked from commit 6f4175a)

(cherry-picked to staging by AndrewGable)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 17, 2025
@OSBotify OSBotify mentioned this pull request Dec 17, 2025
Closed
@OSBotify

OSBotify commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.81-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@inimaga inimaga mentioned this pull request Dec 17, 2025
Closed
7 tasks
@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.84-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amyevans amyevans amyevans approved these changes

@joekaufmanexpensify joekaufmanexpensify Awaiting requested review from joekaufmanexpensify

Assignees

@inimaga inimaga

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inimaga @amyevans @OSBotify