Fix issue where back button returns to confirm detail page after crea… by KocaPepsi · Pull Request #77964 · Expensify/App

KocaPepsi · 2025-12-18T06:17:59Z

Explanation of Change

We should call use setNavigationActionToMicrotaskQueue to ensure all required operations complete before navigation occurs.

Fixed Issues

$ #76657
PROPOSAL: #76657 (comment)

Tests

Open the Expensify app.
Navigate to any workspace chat and create a manual expense.
After creating the manual expense, go to the Reports tab.
In the filter, choose Type: Expense, then tap the expense created in step 2.
In the composer box, tap the + button.
Select Create expense and complete creating another manual expense.
After the expense is created, tap the Back button in the header.
Verify that tapping the Back button in the header returns you to the Reports page.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open the Expensify app.
Navigate to any workspace chat and create a manual expense.
After creating the manual expense, go to the Reports tab.
In the filter, choose Type: Expense, then tap the expense created in step 2.
In the composer box, tap the + button.
Select Create expense and complete creating another manual expense.
After the expense is created, tap the Back button in the header.
Verify that tapping the Back button in the header returns you to the Reports page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

6_6.mp4

Android: mWeb Chrome

4_4.mp4

iOS: Native

5_5.mp4

iOS: mWeb Safari

3_3.mp4

MacOS: Chrome / Safari

1_1.mp4

2_2.mp4

…ting an expense Expensify#76657

melvin-bot · 2025-12-18T06:18:06Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-18T06:26:22Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/IOU.ts	`64.66% <0.00%> (-0.22%)`	⬇️
... and 12 files with indirect coverage changes

joekaufmanexpensify

Makes sense

huult · 2025-12-19T02:07:00Z

@KocaPepsi Could you please update the test steps like this?

1. Open the Expensify app.
2. Navigate to any workspace chat and create a manual expense.
3. After creating the manual expense, go to the Reports tab.
4. In the filter, choose Type: Expense, then tap the expense created in step 2.
5. In the composer box, tap the + button.
6. Select Create expense and complete creating another manual expense.
7. After the expense is created, tap the Back button in the header.
8. Verify that tapping the Back button in the header returns you to the Reports page.

huult · 2025-12-19T02:13:26Z

@KocaPepsi Could you please merge main

…vigation-after-create-expense-76657

huult · 2025-12-19T03:15:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-19.at.10.02.44.mp4

Android: mWeb Chrome

Screen.Recording.2025-12-19.at.10.04.25.mp4

iOS: HybridApp

Screen.Recording.2025-12-19.at.10.08.07.mp4

iOS: mWeb Safari

Screen.Recording.2025-12-19.at.10.09.54.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-12-19.at.09.55.29.mp4

huult · 2025-12-19T03:32:35Z

@KocaPepsi Overall, it looks good and redirects to the correct route, but on the native app it feels a bit odd. When we create an expense, it briefly shows the Reports page before navigating to the search money request report, as shown in the video.

Android: HybridApp

Screen.Recording.2025-12-19.at.10.02.44.mp4

iOS: HybridApp

Screen.Recording.2025-12-19.at.10.08.07.mp4

I think the problem is due to our use of dismissModal, which is causing this behavior.

App/src/libs/actions/IOU.ts

Line 998 in 5e46df2

Navigation.dismissModal();

Could you try updating your alternative solution 1 and see if it works well and provides better behavior?

App/src/libs/actions/IOU.ts

Lines 997 to 1003 in 5e46df2

    
           if (hasMultipleTransactions && reportID) { 
        
               Navigation.dismissModal(); 
        
               Navigation.setNavigationActionToMicrotaskQueue(() => { 
        
                   Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID})); 
        
               }); 
        
               return; 
        
           }

to:

if (hasMultipleTransactions && reportID) {
                // Find and remove the RightModalNavigator instead of dismissing the entire modal
                const rightModalNavigatorRoute = rootState.routes.find((route) => route.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR);
                if (rightModalNavigatorRoute?.key) {
                    Navigation.removeScreenByKey(rightModalNavigatorRoute.key);

                    Navigation.setNavigationActionToMicrotaskQueue(() => {
                        Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID}));
                    });
                }
                return;
            }

KocaPepsi · 2025-12-19T03:41:13Z

Hi @huult,

I will update

huult · 2025-12-19T03:58:07Z

@KocaPepsi Sorry, please stop updating this. If we use it, we will stay on the confirmation screen for a bit.

Screen.Recording.2025-12-19.at.10.57.33.mov

huult

LGTM

mountiny

Thank you! Lets be on a look out for any deploy blockers from this please

OSBotify · 2025-12-19T13:15:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-19T23:59:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.85-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-23T00:33:21Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix issue where back button returns to confirm detail page after crea…

1e2e6cb

…ting an expense Expensify#76657

KocaPepsi requested review from a team as code owners December 18, 2025 06:18

melvin-bot Bot assigned KocaPepsi Dec 18, 2025

melvin-bot Bot requested a review from huult December 18, 2025 06:18

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team December 18, 2025 06:18

joekaufmanexpensify previously approved these changes Dec 18, 2025

View reviewed changes

huult reviewed Dec 19, 2025

View reviewed changes

Comment thread src/libs/actions/IOU.ts Outdated

KocaPepsi added 2 commits December 19, 2025 09:20

Merge remote-tracking branch 'upstream/main' into fix/reports-back-na…

4f9f73d

…vigation-after-create-expense-76657

update code review

5e46df2

KocaPepsi dismissed joekaufmanexpensify’s stale review via 5e46df2 December 19, 2025 02:21

huult approved these changes Dec 19, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny December 19, 2025 03:59

mountiny approved these changes Dec 19, 2025

View reviewed changes

mountiny merged commit 92fea22 into Expensify:main Dec 19, 2025
31 of 32 checks passed

OSBotify mentioned this pull request Dec 19, 2025

Deploy Checklist: New Expensify 2025-12-19 #78170

Closed

87 tasks

melvin-bot Bot mentioned this pull request Dec 23, 2025

[Due for payment 2025-12-30] [$250] Reports - After created new expense, tapping back button returns to confirm detail page #76657

Closed

16 tasks

Conversation

KocaPepsi commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 18, 2025

Uh oh!

codecov Bot commented Dec 18, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Dec 19, 2025

Uh oh!

huult commented Dec 19, 2025

Uh oh!

Uh oh!

huult commented Dec 19, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KocaPepsi commented Dec 19, 2025

Uh oh!

huult commented Dec 19, 2025

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KocaPepsi commented Dec 18, 2025 •

edited

Loading

codecov Bot commented Dec 18, 2025 •

edited by github-actions Bot

Loading

huult commented Dec 19, 2025 •

edited

Loading