fix: 77979 Continue button directs to proper step#78001
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
trjExpensify
left a comment
There was a problem hiding this comment.
global reimbursement follow-up 👍
|
will review today! |
|
I couldn't get past step 2: Screen.Recording.2025-12-19.at.11.19.16.movHere's my requestID: @madmax330 Did we have any changes recently in the BE? |
|
Not related to this PR but we might need to fix it:
Screen.Recording.2025-12-19.at.15.25.50.mov |
|
@hungvu193 I think it popped on our radar during better BBA project. |
Cool. Thanks for letting me know. We can ignore it |
|
@hungvu193 I looked at the logs for your request, I think the Corpay API was just having issues b/c it wasn't returning JSON to us. So you can probably just try again and it will work |
|
Cool. Let me try again 👍 |
|
@MrMuzyk Could you merge main? My app keeps crashing I can't do anything. That's pretty weird. It will happen after I tried to connect bank account in the last steps Screen.Recording.2025-12-19.at.21.25.06.mov |
…9-wrong-step-for-non-usd-verifying-acc
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2025-12-19.at.21.51.19.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.85-0 🚀
|
|
This PR failing because of a regression issue 1.mp4 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀
|
Explanation of Change
Adjusted function triggered when user continues the non USD BBA flow
Fixed Issues
$ #77979
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-18.at.16.43.58.mov