Show no-access modal when delegate tries to update copilots by ShridharGoel · Pull Request #78110 · Expensify/App

ShridharGoel · 2025-12-19T10:19:37Z

Explanation of Change

Show no-access modal when delegate tries to update copilots

Fixed Issues

$ #77446
PROPOSAL: #77446 (comment)

Tests

Precondition: The main Expensifail account has set up Full and Limit copilots in the Security section

Log in the NewDot with the Full Copilot and switch to the main account in Settings
Navigate to the Security section
Tap on the three dots button at the Limit Copilot
Not-so-fast modal should show

Log in the NewDot with the Full Copilot and switch to the main account in Settings
Navigate to the Security section
Tap on the three dots button at the Full Copilot
Not-so-fast modal should show

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-19.at.3.39.04.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-19.at.3.44.00.PM.mov

iOS: Native

Screen.Recording.2025-12-19.at.3.32.19.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-19.at.3.33.42.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-19.at.3.28.24.PM.mov

melvin-bot · 2025-12-19T10:20:14Z

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2025-12-19T10:20:43Z

@truph01 is the assigned C+.

codecov · 2025-12-19T10:28:10Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...c/pages/settings/Security/SecuritySettingsPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

truph01 · 2025-12-19T10:21:56Z

            icon: icons.Pencil,
            onPress: () => {
-                if (isDelegateAccessRestricted) {
+                if (isDelegateAccessRestricted || isActingAsDelegate) {


Suggested change

if (isDelegateAccessRestricted || isActingAsDelegate) {

if (isActingAsDelegate) {

truph01 · 2025-12-19T10:22:16Z

            icon: Expensicons.Trashcan,
            onPress: () => {
-                if (isDelegateAccessRestricted) {
+                if (isDelegateAccessRestricted || isActingAsDelegate) {


Suggested change

if (isDelegateAccessRestricted || isActingAsDelegate) {

if (isActingAsDelegate) {

truph01 · 2025-12-19T10:32:13Z

+                                    if (isActingAsDelegate) {
+                                        setShouldShowRemoveDelegateModal(false);
+                                        showDelegateNoAccessModal();
+                                        return;
+                                    }


Why do we need this logic? We already prevent the user from clicking the "Remove Copilot" button, so is there any chance this logic could still be triggered?

If the session flips to "acting as delegate" after the modal is already open (e.g., user switches to a delegator account in another tab and returns, or future code opens the modal from some other entry point), this check can be useful. What do you think?

@ShridharGoel why inside the onConfirm though?

@grgia Because if the user somehow views the modal and clicks on confirm, but they are a delegate, then the remove-copilot modal will close and instead the "no-access" one will show.

Do you have a video of this flow on your branch

Screen.Recording.2025-12-20.at.3.51.12.PM.mov

Screen.Recording.2025-12-20.at.3.49.46.PM.mov

truph01 · 2025-12-19T10:47:46Z

+                        if (isActingAsDelegate) {
+                            showDelegateNoAccessModal();
+                            return;
+                        }


I don’t think we need this logic. We can still allow users to open the popover, but prevent them from selecting certain options within it.

truph01 · 2025-12-19T10:55:49Z

@grgia Sorry, I mistakenly approved this PR.

Please hold off on your review until I finish it on my side.

truph01 · 2025-12-19T11:04:59Z

                }),
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
-        [delegates, translate, styles, personalDetails, errorFields, windowWidth, selectedEmail],
+        [delegates, translate, styles, personalDetails, errorFields, windowWidth, selectedEmail, isActingAsDelegate, showDelegateNoAccessModal],


Suggested change

[delegates, translate, styles, personalDetails, errorFields, windowWidth, selectedEmail, isActingAsDelegate, showDelegateNoAccessModal],

[delegates, translate, styles, personalDetails, errorFields, windowWidth, selectedEmail],

…Modal

truph01 · 2025-12-23T15:00:12Z

@ShridharGoel Could you help merge main?

truph01 · 2025-12-23T15:05:36Z

            icon: icons.Pencil,
            onPress: () => {
-                if (isDelegateAccessRestricted) {
+                if (isActingAsDelegate) {


@ShridharGoel Is it in the scope of this issue?

I think we should be doing it to ensure that change access levels is also restricted. Do you think we should revert this?

I think we should revert. Because in the OP of the bug, it only mentioned "Remove copilot" option, not the "Change access level" option

truph01 · 2025-12-23T15:17:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-23.at.22.17.18.mov

Android: mWeb Chrome

Screen.Recording.2025-12-23.at.22.13.58.mov

iOS: HybridApp

Screen.Recording.2025-12-23.at.22.16.38.mov

iOS: mWeb Safari

Screen.Recording.2025-12-23.at.22.10.43.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-23.at.22.09.07.mov

…Modal

ShridharGoel · 2025-12-23T15:18:45Z

Merged main

ShridharGoel · 2025-12-23T17:19:48Z

@grgia This is ready for your review.

ShridharGoel · 2025-12-29T14:14:18Z

@Valforte Do you think this can be merged?

OSBotify · 2025-12-29T19:31:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-30T15:20:11Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.2.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-31T18:34:07Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.89-6 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Show no-access modal when delegate tries to update copilots

dd81f0b

ShridharGoel requested review from a team as code owners December 19, 2025 10:19

melvin-bot Bot assigned ShridharGoel Dec 19, 2025

melvin-bot Bot requested review from JmillsExpensify and Valforte and removed request for a team December 19, 2025 10:19

truph01 approved these changes Dec 19, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia December 19, 2025 10:48

Show no-access modal when delegate tries to update copilots

fd4616f

truph01 suggested changes Dec 19, 2025

View reviewed changes

ShridharGoel added 2 commits December 19, 2025 17:15

remove extra deps

57a4108

Merge branch 'main' of https://github.com/Expensify/App into delegate…

84d4786

…Modal

truph01 reviewed Dec 23, 2025

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into delegate…

58bcdc6

…Modal

Change check for access level

f84f6b5

truph01 approved these changes Dec 23, 2025

View reviewed changes

Valforte approved these changes Dec 26, 2025

View reviewed changes

Valforte merged commit a90af9b into Expensify:main Dec 29, 2025
32 checks passed

OSBotify mentioned this pull request Dec 30, 2025

Deploy Checklist: New Expensify 2025-12-30 #78583

Closed

56 tasks

melvin-bot Bot mentioned this pull request Dec 31, 2025

[Due for payment 2026-01-07] [$250] Security - No warning message when "Full coplilot" removes "Limit copilot" #77446

Closed

7 tasks

ChavdaSachin mentioned this pull request Jan 19, 2026

[$250] Copilot: Removing Copilot Triggers Auto-Populated New Account Sign-Up Flow #79818

Closed

7 tasks

	if (isDelegateAccessRestricted \|\| isActingAsDelegate) {
	if (isActingAsDelegate) {

	[delegates, translate, styles, personalDetails, errorFields, windowWidth, selectedEmail, isActingAsDelegate, showDelegateNoAccessModal],
	[delegates, translate, styles, personalDetails, errorFields, windowWidth, selectedEmail],

Conversation

ShridharGoel commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 19, 2025

Uh oh!

ShridharGoel commented Dec 19, 2025

Uh oh!

codecov Bot commented Dec 19, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

truph01 commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

truph01 commented Dec 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

truph01 commented Dec 23, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented Dec 23, 2025

Uh oh!

ShridharGoel commented Dec 23, 2025

Uh oh!

ShridharGoel commented Dec 29, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 29, 2025

Uh oh!

OSBotify commented Dec 30, 2025

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShridharGoel commented Dec 19, 2025 •

edited

Loading

codecov Bot commented Dec 19, 2025 •

edited by github-actions Bot

Loading

truph01 commented Dec 19, 2025 •

edited

Loading