Skip to content

Tgolen fix flexbox header #78150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 1 commit into from
Dec 19, 2025
+9 −1
Merged

Tgolen fix flexbox header #78150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/pages/workspace/companyCards/WorkspaceCompanyCardsTableHeaderButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,11 @@ function WorkspaceCompanyCardsTableHeaderButtons({policyID, selectedFeed, should
<View
style={[styles.alignItemsCenter, styles.gap3, shouldShowNarrowLayout ? [styles.flexColumnReverse, styles.w100, styles.alignItemsStretch, styles.gap5] : styles.flexRow]}
>
{shouldDisplayTableComponents && <Table.SearchBar />}
{shouldDisplayTableComponents && (

@github-actions github-actions Bot Dec 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ PERF-4 (docs)

Creating a new array on every render causes unnecessary re-renders. When passing a single style, pass the style object directly instead of wrapping it in an array.

Suggested fix:

<View style={styles.mnw200}>
    <Table.SearchBar />
</View>

<View style={[styles.mnw200]}>
<Table.SearchBar />
</View>
)}
<View style={[styles.flexRow, styles.gap3]}>
{shouldDisplayTableComponents && <Table.FilterButtons style={shouldShowNarrowLayout && [styles.flex1]} />}
<ButtonWithDropdownMenu
Expand Down
4 changes: 4 additions & 0 deletions src/styles/utils/sizing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ export default {
minWidth: 120,
},

mnw200: {
minWidth: 200,
},

w40: {
width: '40%',
},
Expand Down
Loading